Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No channel data for channel/nick" errors when trying to handle mode changes #1731

Open
Half-Shot opened this issue Jun 2, 2023 · 1 comment
Open

"No channel data for channel/nick" errors when trying to handle mode changes #1731

Half-Shot opened this issue Jun 2, 2023 · 1 comment
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@Half-Shot
Copy link
Contributor

We fetch the BridgedClient of the user being opped, and then get the prefix's for that username. It sounds like the .chanData request on the client is failing, and this is causing the bridge to not handle the mode change. I'd expect to see some data for this channel as we only emit a +mode if we know the channel. https://github.com/matrix-org/node-irc/blob/985b3380857e5d816934bf1c1bfc44ed60e70081/src/irc.ts#L513-L517
@Half-Shot Half-Shot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jun 2, 2023
@Half-Shot Half-Shot mentioned this issue Jun 2, 2023
Open
@Half-Shot
Copy link
Contributor Author

This should be fixed in #1732 .

@progval progval mentioned this issue Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Half-Shot