Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using virtual type to configure plugin, interceptor method cannot be … #33981

Closed
wants to merge 5 commits into from
Closed

Using virtual type to configure plugin, interceptor method cannot be … #33981

wants to merge 5 commits into from

Conversation

GrassH
Copy link

@GrassH GrassH commented Sep 3, 2021 •
edited
Loading

Description (*)

Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command #33980

Manual testing scenarios (*)

  1. rm generated/* -Rf && bin/magento test:plugin:calculate
    Result is 0;
  2. rm generated/* -Rf && bin/magento setup:di:compile && bin/magento test:plugin:calculate
    Result is 0;

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@GrassH
Using virtual type to configure plugin, interceptor method cannot be …
d1a3e12 
…generated correctly in setup:di:compile command
@m2-assistant
Copy link

m2-assistant bot commented Sep 3, 2021

Hi @GrassH. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@GrassH @ihor-sviziev
Update setup/src/Magento/Setup/Module/Di/Code/Generator/InterceptionC…
5828708 
…onfigurationBuilder.php

Co-authored-by: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added the Severity: S1 Affects critical data or functionality and forces users to employ a workaround. label Sep 3, 2021
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 3, 2021
ihor-sviziev
ihor-sviziev requested changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GrassH,
Could you check failing unit tests and cover your changes with some test?

@GrassH
Copy link
Author

GrassH commented Sep 6, 2021

Hi @ihor-sviziev, added tests, please check.

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-deployment-service
Copy link

Hi @GrassH. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @GrassH, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@GrassH
Copy link
Author

GrassH commented Sep 9, 2021

@magento give me test instance

@magento-deployment-service
Copy link

Hi @GrassH. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @GrassH, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@GrassH
Copy link
Author

GrassH commented Sep 9, 2021

@magento give me test instance

@magento-deployment-service
Copy link

Hi @GrassH. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @GrassH, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@GrassH
Copy link
Author

GrassH commented Sep 9, 2021

@magento give me test instance

@magento-deployment-service
Copy link

Hi @GrassH. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @GrassH, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@GrassH
Copy link
Author

GrassH commented Sep 9, 2021

@magento give me test instance

@magento-deployment-service
Copy link

Hi @GrassH. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @GrassH, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Sep 9, 2021
@hostep hostep removed their assignment Sep 9, 2021
@Den4ik
Copy link
Contributor

Den4ik commented Sep 10, 2021

@magento run Functional Tests CE, Functional Tests B2B, Functional Tests EE, Sample Data Tests CE, Sample Data Tests B2B, Sample Data Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests B2B, Functional Tests EE, Sample Data Tests CE, Sample Data Tests B2B, Sample Data Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev
ihor-sviziev requested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts and failing tests

@ishakhsuvarov
Copy link
Contributor

Hi

I am closing this PR for now as it seems like it has become stale and still needs work.

Please feel free to reopen if you wish to continue.

Thanks!

@GrassH GrassH mentioned this pull request Nov 2, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hostep hostep hostep left review comments

@ihor-sviziev ihor-sviziev ihor-sviziev requested changes

@Den4ik Den4ik Awaiting requested review from Den4ik

Assignees

@Den4ik Den4ik

@ihor-sviziev ihor-sviziev

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Setup Priority: P3 May be fixed according to the position in the backlog. Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
7 participants
@GrassH @ihor-sviziev @magento-engcom-team @sivaschenko @Den4ik @ishakhsuvarov @hostep