Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using virtual type to configure plugin, interceptor method cannot be … #33981

Closed
wants to merge 5 commits into from
Closed

Using virtual type to configure plugin, interceptor method cannot be … #33981

wants to merge 5 commits into from

Commits on Sep 3, 2021

  1. Using virtual type to configure plugin, interceptor method cannot be … 

    …generated correctly in setup:di:compile command
    @GrassH
    GrassH committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    d1a3e12 View commit details
    Browse the repository at this point in the history

  2. Update setup/src/Magento/Setup/Module/Di/Code/Generator/InterceptionC… 

    …onfigurationBuilder.php

Co-authored-by: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
    @GrassH @ihor-sviziev
    GrassH and ihor-sviziev authored Sep 3, 2021
    Configuration menu
    Copy the full SHA
    5828708 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Added tests for magento#33981 (magento#33980)

    @GrassH
    GrassH committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    adc20b4 View commit details
    Browse the repository at this point in the history

  2. Merge branch '2.4-develop' into develop

    @GrassH
    GrassH authored Sep 6, 2021
    Configuration menu
    Copy the full SHA
    08e41db View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Using virtual type to configure plugin, interceptor method cannot be … 

    …generated correctly in setup:di:compile command

1. Make changes in constructor backward compatible
2. Fix static tests
- extract to separate method
- replace array_merge in loop with a single array_merge
    @ihor-sviziev
    ihor-sviziev committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    7ad5055 View commit details
    Browse the repository at this point in the history