Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#33980: Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command #38141

Open
wants to merge 25 commits into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#33980: Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command #38141

wants to merge 25 commits into from

Conversation

GrassH
Copy link

@GrassH GrassH commented Nov 2, 2023

Description (*)

Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command

Related Pull Requests

#33981

Fixed Issues (if relevant)

  1. Fixes Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command #33980

Manual testing scenarios (*)

  1. rm generated/* -Rf && bin/magento test:plugin:calculate
    Result is 0;
  2. rm generated/* -Rf && bin/magento setup:di:compile && bin/magento test:plugin:calculate
    Result is 0;

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

GrassH and others added 6 commits September 3, 2021 14:37
@GrassH
Using virtual type to configure plugin, interceptor method cannot be …
d1a3e12 
…generated correctly in setup:di:compile command
@GrassH @ihor-sviziev
Update setup/src/Magento/Setup/Module/Di/Code/Generator/InterceptionC…
5828708 
…onfigurationBuilder.php

Co-authored-by: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
@GrassH
Added tests for magento#33981 (magento#33980)
adc20b4
@GrassH
Merge branch '2.4-develop' into develop
08e41db
@ihor-sviziev
Using virtual type to configure plugin, interceptor method cannot be …
7ad5055 
…generated correctly in setup:di:compile command

1. Make changes in constructor backward compatible
2. Fix static tests
- extract to separate method
- replace array_merge in loop with a single array_merge
@GrassH
Using virtual type to configure plugin, interceptor method cannot be …
3c73535 
…generated correctly in setup:di:compile command magento#33980
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 2, 2023

Hi @GrassH. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Nov 2, 2023
@GrassH
Copy link
Author

GrassH commented Nov 2, 2023

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@GrassH GrassH changed the title Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command magento/magento2#33980: Using virtual type to configure plugin, interceptor method cannot be generated correctly in setup:di:compile command Nov 2, 2023
@GrassH
Copy link
Author

GrassH commented Nov 3, 2023

@magento run Sample Data Tests CE,Sample Data Tests B2B,Sample Data Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@GrassH
Copy link
Author

GrassH commented Nov 3, 2023

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@Den4ik Den4ik self-requested a review November 3, 2023 07:28
@Den4ik Den4ik self-assigned this Nov 3, 2023
@GrassH
Copy link
Author

GrassH commented Nov 3, 2023

@magento run Functional Tests CE, Functional Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@GrassH
Copy link
Author

GrassH commented Nov 6, 2023

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@GrassH
Copy link
Author

GrassH commented Jan 30, 2024 •
edited
Loading

All failed test cases are not related to this PR, please review again.

Functional Tests B2B
Functional Tests B2B

Functional Tests CE
Functional Tests CE

Functional Tests EE
Functional Tests EE

Integration Tests
Integration Tests

WebAPI Tests
WebAPI Tests

@GrassH GrassH requested a review from Den4ik January 30, 2024 08:50
@Den4ik
Copy link
Contributor

Den4ik commented Mar 18, 2024

@magento run all tests

@Den4ik
Copy link
Contributor

Den4ik commented Mar 19, 2024

@magento run WebAPI Tests

@Den4ik
Copy link
Contributor

Den4ik commented Mar 27, 2024

@magento run Functional Tests CE

1 similar comment
@Den4ik
Copy link
Contributor

Den4ik commented Apr 3, 2024

@magento run Functional Tests CE

@GrassH
Copy link
Author

GrassH commented May 23, 2024

@magento run all tests

@GrassH
Copy link
Author

GrassH commented May 28, 2024

@magento run all tests

@Den4ik
Copy link
Contributor

Den4ik commented Jun 4, 2024

@magento run WebAPI Tests

@GrassH
Copy link
Author

GrassH commented Nov 5, 2024

@magento run all tests

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Nov 13, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@GrassH
Copy link
Author

GrassH commented Nov 15, 2024

@magento run Static Tests,Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Database Compare, Functional Tests CE, Functional Tests EE, Integration Tests, Magento Health Index, Semantic Version Checker, Unit Tests, WebAPI Tests

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Nov 15, 2024
@engcom-Hotel
Copy link
Contributor

@magento Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

@engcom-Hotel
Copy link
Contributor

@magento Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

@Den4ik Den4ik Awaiting requested review from Den4ik

Assignees

@Den4ik Den4ik

@engcom-Hotel engcom-Hotel

Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Project: Community Picked PRs upvoted by the community Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Community Dashboard
Status: Ready for Testing
Milestone
No milestone
6 participants
@GrassH @Den4ik @engcom-Hotel @engcom-Bravo @Priyakshic @ihor-sviziev