Skip to content

[Backport] Improving-the-uploaded-images-styling-view-2.2 #20793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

#20786

Fixed Issues (if relevant)

  1. [CMS] Improving the uploaded images styling view #20787: [CMS] File upload preview style issue

Manual testing scenarios (*)

  1. Open a CMS page or block
  2. Click on the Insert Image from the content field
  3. Upload a new image or check the existing ones

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Jan 30, 2019

Hi @amol2jcommerce. Please, try to avoid creating ports until an original issue is merged into mainline. The original issue might or might not be accepted. A port is useful only in case if an original issue is accepted. Before that point, it's useless and creates additional overhead in the general PR processing flow.
Moreover, changes to an original PR might be requested. In that case, you need to do double work to reflect all changes in a port.
Thank you.

@eduard13
Copy link
Contributor

A backport solution has been created #21110.

@eduard13 eduard13 closed this Feb 10, 2019
@ghost
Copy link

ghost commented Feb 10, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants