Skip to content

[CMS] Improving the uploaded images styling view #20787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jan 30, 2019

Description (*)

This PR fixes the styling issue for uploaded images.

Fixed Issues (if relevant)

  1. [CMS] File upload preview style issue #20786: [CMS] File upload preview style issue
  2. ...

Manual testing scenarios (*)

  1. Open a CMS page or block
  2. Click on the Insert Image from the content field
  3. Upload a new image or check the existing ones

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@eduard13
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, here is your new Magento instance.
Admin access: https://pr-20787.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@eduard13 eduard13 changed the title Improving the uploaded images styling view [CMS] Improving the uploaded images styling view Jan 30, 2019
@rogyar
Copy link
Contributor

rogyar commented Jan 30, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-20787.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4051 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 10, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants