Fixed store switcher doesn't work multistore setup with different product urls issue

[janakbhimani]

Description (*)

Fixed store switcher doesn't work multistore setup with different product urls issue

Fixed Issues (if relevant)

1. Store switcher doesn't work multistore setup with different product urls #19714: Fixed store switcher doesn't work multistore setup with different product urls issue

Manual testing scenarios (*)

1. N/A

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @janakbhimani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sreichel]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @sreichel. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @sreichel, here is your new Magento instance.
Admin access: https://pr-19798.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[sreichel]

LGTM

[davidverholen]

It seems to be a great addition, did not run into this before. Just one small comment although I'm not sure if it's just personal preference

[davidverholen]

@janakbhimani thx! There is a second pull request basically with the same fix and im currently trying to figure out which one should be merged.

You changed the findOneByData to findAllByData. Do you maybe still remember a usecase where this would be necessary? If it has no impact on functionality I would argue the findOneByData is probably better regarding performance (see #20093 for reference)

[janakbhimani]

Hi @davidverholen,
I have updated the code, previously Travis got failed, so I have fixed it, therefore multiple commits are created in this PR, but finally all checks are pass and latest commit is working commit 8a05dbb

Thanks.

[magento-engcom-team]

Hi @davidverholen, thank you for the review.
ENGCOM-4050 has been created to process this Pull Request

[magento-engcom-team]

@janakbhimani thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[sdzhepa]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-19798.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[ghost]

Hi @janakbhimani, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.