Skip to content

[Backport] Fixed store switcher doesn't work multistore setup with different product urls issue #21140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

janakbhimani
Copy link

Original Pull Request

#19798

Description (*)

Fixed store switcher doesn't work multistore setup with different product urls issue

Fixed Issues (if relevant)

  1. Store switcher doesn't work multistore setup with different product urls #19714: Fixed store switcher doesn't work multistore setup with different product urls issue

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @janakbhimani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4224 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 13, 2019

Hi @janakbhimani, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2019
@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019
@janakbhimani janakbhimani deleted the 2.2-develop-PR-port-19798 branch December 20, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants