#14674 Add ChangeStoreCode switcher to StoreSwither pool of swichers …

[vgerassimov]

…that changes store code in redirect url from current store code to target store code

Description (*)

Issue started after deleting part of code responsible for replacing store codes in URL in this commit: 68a2605#diff-285a7e574ab3ef96f4df4d9b1d326428L144

Fixed Issues (if relevant)

1. Language Switcher is not working on Magento 2.2.3 #14674: Language Switcher is not working on Magento 2.2.3

Manual testing scenarios (*)

1. Enable web/url/use_store
2. Go to any page of your multi-store website
3. Switch scope using /stores/store/switch/?___store=<target_store_code>&___from_store=<current_store_code>&uenc=<base64encoded_reference_link>

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @vgerassimov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[hostep]

@vgerassimov: does this fix the same issue as #19798 attempts to fix?

Also I'm not sure if doing a simple str_replace will be able to handle translated category or product url's?
For example, you can have a category with url 'cat-english.html' in an English storeview and 'cat-french.html' in a French storeview.
I don't think this solution is capable of handling that?

[vgerassimov]

Hi! No this is a separate one and related to switching scopes when web/url/use_store is enabled, i.e. http://example.com/en_us switch to http://example.com/en_gb using /stores/store/switch (Magento\Store\Controller\Store\SwitchAction) which is used by data-post elements. If we do not apply this str_replace than after all switch actions is done $targetUrl parameter is still = http://example.com/en_us which leads us to stay on same page in same scope, while all action from switch pool (vendor/magento/module-store/etc/di.xml:428) has been applied including changing scope in cookies (\Magento\Store\Model\StoreSwitcher\ManagePrivateContent::switch). Reason why str_replace is used – that it was in origin Magento code, which has been deleted during refactoring described in PR Description (68a2605#diff-285a7e574ab3ef96f4df4d9b1d326428L144), which means it was working before as well. Best regards, Vladimir Gerassimov

…

On 31 Jan 2019, at 14:59, Pieter Hoste ***@***.***> wrote: @vgerassimov <https://github.com/vgerassimov>: does this fix the same issue as #19798 <#19798> attempts to fix? Also I'm not sure if doing a simple str_replace will be able to handle translated category or product url's? For example, you can have a category with url 'cat-english.html' in an English storeview and 'cat-french.html' in a French storeview. I don't think this solution is capable of handling that? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20851 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASQuyCEoiqLVQx_N84Yr0PMFSjQHO-4fks5vIujFgaJpZM4acGB6>.

[hostep]

Hi @vgerassimov

Can you help me out a little bit by explaining exactly what you are trying to achieve with this PR?
If I understand it correctly, you are talking about the store switcher (which appears in the footer) and not the store view switcher (which appears in the header), correct?
Issue #14674 talks about the storeview switcher btw, but that's not very important I think.

Here are steps I followed with some test cases:

1. Setup Magento 2.3.0
2. In admin: set Stores > Configuration > General > Web > Url Options > Add Store Code to Urls > Yes
3. In admin: create a website/store/store view structure like this:

Website	Store	Store view
Main Website	US Store (code: us)	US Store View (code: en_us)
Main Website	GB Store (code: gb)	GB Store View (code: en_gb)

4. In admin: create 2 categories, with the following properties:

Scope	Name	Url Key
All Store Views	Cat 1	cat-1
All Store Views	Cat 2	cat-2
US Store View	Cat 2 US	cat-2-us
GB Store View	Cat 2 GB	cat-2-gb

5. Reindex & flush caches
6. In the frontend, follow the following scenario's and look at the results:

Scenario	Start page	Switch to Store	Expected Result	Result in vanilla 2.3.0	Result from this PR
Homepage	/en_us/	GB	/en_gb/	/en_gb/	/en_gb/
Cat 1	/en_us/cat-1.html	GB	/en_gb/cat-1.html	/en_gb/cat-1.html	/en_gb/
Cat 2	/en_us/cat-2-us.html	GB	/en_gb/cat-2-gb.html	/en_gb/cat-2-us.html	/en_gb/

The results in bold are the ones which don't match the expected result.
So this PR seems to introduces more problems then it fixes.

If I'm mistaken in any of these steps, please let me know and I can re-test then. Thanks!

[slavvka]

@magento run all tests

[slavvka]

Hey @vgerassimov Thank you for the contribution. Could you please review the comment #20851 (comment) because it seems that there are issues in your solution.

[vgerassimov]

@slavvka Hello!

After upgrading to the latest magento versions this issue has been fixed, sorry for long answering, missed previous comment notification probably.

[m2-assistant]

Hi @vgerassimov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[slavvka]

Oh, Thank you for verification and for your efforts!