Skip to content

Fix to allow use decimals less then 1 in subproducts qty. #14752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2018

Conversation

likemusic
Copy link
Contributor

Quick fix to allow use decimals less then 1 in subproducts qty.

The same as #14693 but from fork.

Description

There is impossible to place order from grouped product where subproducts qty less then one.

Fixed Issues (if relevant)

  1. 'validate-grouped-qty' validation is meaningless #14692: 'validate-grouped-qty' validation is meaningless

Manual testing scenarios

  1. Set "Qty Uses Decimals" = Yes and Minimum Qty Allowed in Shopping Cart" = 0.01 for all products on any grouped product.
  2. Go to groped product page on frontend.
  3. Put for all suproducts qty less than 1.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fix to allow use decimals less then 1 in subproducts qty.
@magento-engcom-team
Copy link
Contributor

Hi @likemusic. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@likemusic
Copy link
Contributor Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @likemusic. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @likemusic, here is your Magento instance.
Admin access: https://i-14752-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@likemusic
Copy link
Contributor Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @likemusic. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @likemusic, here is your Magento instance.
Admin access: https://i-14752-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants