Skip to content

Update validation.js #14693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update validation.js #14693

wants to merge 1 commit into from

Conversation

likemusic
Copy link
Contributor

@likemusic likemusic commented Apr 13, 2018

Fix to allow use decimals less then 1 in subproducts qty.

Description

There is impossible to place order from grouped product where subproducts qty less then one.

Fixed Issues (if relevant)

  1. 'validate-grouped-qty' validation is meaningless #14692: 'validate-grouped-qty' validation is meaningless

Manual testing scenarios

  1. Set "Qty Uses Decimals" = Yes and Minimum Qty Allowed in Shopping Cart" = 0.01 for all products on any grouped product.
  2. Go to groped product page on frontend.
  3. Put for all suproducts qty less than 1.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fix to allow use decimals less then 1 in subproducts qty.
@VladimirZaets
Copy link
Contributor

VladimirZaets commented Apr 16, 2018

@likemusic Unfortunately, we can't accept PR from the Magento repository, please fork Magento repository and create new PR from your fork.

@likemusic likemusic deleted the likemusic-patch-1 branch April 18, 2018 08:00
@likemusic
Copy link
Contributor Author

By the way, why I can create branch in official repo? Because I become member of "Magento" organization?
I did it by accident. But perhaps it would be better not to be able to create new branches in off repository to all megento organization members?

@orlangur
Copy link
Contributor

@likemusic probably because otherwise it is not possible to reopen issues / change assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants