Skip to content

[Backport] Fix to allow use decimals less then 1 in subproducts qty #15407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2018
Merged

[Backport] Fix to allow use decimals less then 1 in subproducts qty #15407

merged 1 commit into from
May 23, 2018

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented May 21, 2018

Original PR: #14752

Description

It is impossible to place an order from grouped product where subproducts qty less than one.

Fixed Issues (if relevant)

  1. 'validate-grouped-qty' validation is meaningless #14692: 'validate-grouped-qty' validation is meaningless

Manual testing scenarios

  1. Set "Qty Uses Decimals" = Yes and Minimum Qty Allowed in Shopping Cart" = 0.01 for all products on any grouped product.
  2. Go to grouped product page on storefront.
  3. Put for all suproducts qty less than 1.

@miguelbalparda miguelbalparda self-assigned this May 22, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone May 22, 2018
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1639 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request May 23, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit e8087c5 into magento:2.1-develop May 23, 2018
magento-engcom-team pushed a commit that referenced this pull request May 23, 2018
ENGCOM-1639: [Backport] Fix to allow use decimals less then 1 in subp…
2535b73 
…roducts qty #15407
@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
3 participants
@rogyar @magento-engcom-team @miguelbalparda