Quick fix for pr from SWAT team #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftedreality
previously approved these changes
Jun 26, 2020
bbatsche
previously approved these changes
Jun 26, 2020
| @@ -20,7 +20,10 @@ class InvalidateLogger extends \Magento\Framework\Cache\InvalidateLogger | |||
| */ | |||
| public function execute($invalidateInfo) | |||
| { | |||
| $invalidateInfo['trace'] = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS); | |||
| if (is_array($invalidateInfo)) { | |||
| $invalidateInfo['trace'] = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS); | |||
There was a problem hiding this comment.
We're ok with not always having this info?
There was a problem hiding this comment.
This should be is something to fix for SWAT team next time
There was a problem hiding this comment.
@Alkar778 are we ok with this for now?
There was a problem hiding this comment.
This debug backtrace is the main goal of this improvement.
I will try to fix it in a couple of hours
shiftedreality
previously approved these changes
Jun 26, 2020
shiftedreality
added
Release Line: 1.0
Release: 1.0.5
Progress: testing in progress
oshmyheliuk
dismissed stale reviews from shiftedreality and bbatsche
via
6ee5174
bbatsche
approved these changes
Jun 26, 2020
shiftedreality
approved these changes
Jun 26, 2020
|
QA approved |
andriyShevtsov
added
Progress: approved
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Apr 8, 2024
bump version 1.0.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for the latest release.
https://jira.corp.magento.com/browse/MCLOUD-6156
Associated documentation updates
magento/devdocs#7462
Contribution checklist