Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Magento-cloud-components: Release 1.0.5 #7462

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Magento-cloud-components: Release 1.0.5 #7462

merged 4 commits into from
Jun 26, 2020

Conversation

YPyltiai
Copy link
Contributor

@YPyltiai YPyltiai commented Jun 26, 2020

Purpose of this pull request

Added release notes for Magento Cloud Components v1.0.5 release.

Affected DevDocs pages

https://devdocs.magento.com/cloud/release-notes/mcc-release-notes.html

whatsnew
Added Magento Cloud Components v1.0.5 release notes.

@magento-engcom-team
Copy link

@YPyltiai thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@YPyltiai YPyltiai changed the title Release 1.0.5 Magento-cloud-components: Release 1.0.5 Jun 26, 2020
@YPyltiai YPyltiai requested review from hguthrie and meker12 June 26, 2020 16:48
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@jeff-matthews jeff-matthews added the Internal Dev Differentiates work between community and Magento staff label Jun 26, 2020
Co-authored-by: Margaret Eker <meker@adobe.com>
Copy link
Member

@bbatsche bbatsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be other third party modules causing this issue as well

## v1.0.5
*Release date: June 26, 2020*<br/>

- {:.fix}Fixed an issue introduced in package version 1.0.4 with cache flush operation through Fastly extension failing during the deploy phase, causing the deployment to be interrupted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- {:.fix}Fixed an issue introduced in package version 1.0.4 with cache flush operation through Fastly extension failing during the deploy phase, causing the deployment to be interrupted.
- {:.fix}Fixed an issue introduced in package version 1.0.4 with cache flush operation failing during the deploy phase, causing the deployment to be interrupted.

Copy link
Contributor

@michaelcasey316 michaelcasey316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the changes Margaret suggested are applied, it looks good to me.

@@ -11,8 +11,13 @@ The [Magento Cloud Components](https://github.com/magento/magento-cloud-componen

The `{{site.data.var.mcc-package}}` package uses the following version sequence: `<major>.<minor>.<patch>`.

## v1.0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbatsche Is this version OK?

## v1.0.5
*Release date: June 26, 2020*<br/>

- {:.fix}Fixed an issue introduced in {{site.data.var.mcc-package}} version 1.0.4 that caused the flush cache operation initiated by the Fastly extension to fail during the deploy phase, which interrupts deployment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last clause indicates the the deploy phase interrupts deployment. perhaps a little fix...

Suggested change
- {:.fix}Fixed an issue introduced in {{site.data.var.mcc-package}} version 1.0.4 that caused the flush cache operation initiated by the Fastly extension to fail during the deploy phase, which interrupts deployment.
- {:.fix}Fixed an issue introduced in {{site.data.var.mcc-package}} version 1.0.4 that caused the flush cache operation initiated by the Fastly extension to fail during the deploy phase, interrupting the deployment process.

YPyltiai and others added 2 commits June 26, 2020 12:05
@YPyltiai
Copy link
Contributor Author

@meker12 , @hguthrie , @bbatsche - merged all change requests. If looks good - please squash & merge. Thanks!

@meker12
Copy link
Contributor

meker12 commented Jun 26, 2020

running tests

@meker12 meker12 merged commit a46cd6e into magento:master Jun 26, 2020
@ghost
Copy link

ghost commented Jun 26, 2020

Hi @YPyltiai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants