Skip to content

Quick fix for pr from SWAT team #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2020
Merged

Quick fix for pr from SWAT team #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5bb4dc2
Quick fix for pr from SWAT team
oshmyheliuk Jun 26, 2020
ac3d2b3
Quick fix for pr from SWAT team
oshmyheliuk Jun 26, 2020
2d056d9
Merge branch '1.0' into swat-pr-fix
oshmyheliuk Jun 26, 2020
4729c05
Quick fix for pr from SWAT team
oshmyheliuk Jun 26, 2020
6ee5174
Merge remote-tracking branch 'origin/swat-pr-fix' into swat-pr-fix
oshmyheliuk Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Model/Cache/InvalidateLogger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,15 @@ class InvalidateLogger extends \Magento\Framework\Cache\InvalidateLogger
*/
public function execute($invalidateInfo)
{
$invalidateInfo['trace'] = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
if (is_array($invalidateInfo)) {
$invalidateInfo['trace'] = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're ok with not always having this info?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be is something to fix for SWAT team next time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alkar778 are we ok with this for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This debug backtrace is the main goal of this improvement.
I will try to fix it in a couple of hours

} elseif (is_string($invalidateInfo)) {
$invalidateInfo = [
'main' => $invalidateInfo,
'trace' => debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS)
];
}

parent::execute($invalidateInfo);
}
}
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "magento/magento-cloud-components",
"description": "Cloud Components Module for Magento 2.x",
"type": "magento2-module",
"version": "1.0.4",
"version": "1.0.5",
"require": {
"php": "^7.0",
"ext-json": "*",
Expand Down