Move XLink nodes nad XLink properties to a new dai::internal namespace #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-core into lnotspotl/internal_xlink
lnotspotl
changed the title
|
Great to see, having this |
moratom
approved these changes
May 19, 2025
moratom
approved these changes
May 19, 2025
There was a problem hiding this comment.
Not sure if we'd still want this? We can keep it in though, might come in handy.
There was a problem hiding this comment.
The example doesn't compile/run anymore, so we can just add a TODO to port to v3.
There was a problem hiding this comment.
turns out the getPipeline function wasn't used anywhere. I therefore removed it
There was a problem hiding this comment.
Better to use some other node for that purpuse, no need to use XLinks
There was a problem hiding this comment.
Better to add a TODO that it needs porting to v3
|
Will wait for the CI to finish and then I'll perform the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
XLinknodes andXLinkproperties to a newly introduceddai::internalnamespace. This shall be a namespace with necessary public implementation that is not meant to be used by the user due to its potentially unstable API. This PR should be reviewed alongside the other opened FW PRs on Gitlab. Changes necessary were minimal.