Renamed user--2 to user-round- #1638

jmsv · 2023-10-26T19:21:55Z

What is the purpose of this pull request?

Rename icons

Description

Renamed all user-*-2 icons to user-round-* as-discussed in #1620, using script from #1630:

node ./scripts/renameIcon.mjs user-2 user-round
node ./scripts/renameIcon.mjs user-check-2 user-round-check
node ./scripts/renameIcon.mjs user-circle-2 user-round-circle
node ./scripts/renameIcon.mjs user-cog-2 user-round-cog
node ./scripts/renameIcon.mjs user-minus-2 user-round-minus
node ./scripts/renameIcon.mjs user-plus-2 user-round-plus
node ./scripts/renameIcon.mjs user-search-2 user-round-search
node ./scripts/renameIcon.mjs user-square-2 user-round-square
node ./scripts/renameIcon.mjs user-x-2 user-round-x
node ./scripts/renameIcon.mjs users-2 users-round

I've read the Contribution Guidelines.
I've checked if there was an existing PR that solves the same issue.

github-actions · 2023-10-26T19:22:14Z

Added or changed icons

Preview cohesion

Preview stroke widths

DPI Preview (24px)

Icon X-rays

jguddas

LGTM

jguddas · 2023-10-26T19:50:55Z

One question, how do we decide if it should be user-square or square-user?

jmsv · 2023-10-26T20:06:13Z

One question, how do we decide if it should be user-square or square-user?

I reckon user-square makes more sense since the user is the main subject. There's also user-circle in a similar format.

jmsv · 2023-10-26T20:07:09Z

Vercel build failed but I can't see why 🤔

jguddas · 2023-10-26T20:07:46Z

Vercel build failed but I can't see why 🤔

Probably permission issue.

jguddas · 2023-10-26T20:14:06Z

One question, how do we decide if it should be user-square or square-user?

I reckon user-square makes more sense since the user is the main subject. There's also user-circle in a similar format.

Good point, pretty important part of the naming convention IMO.

Otherwise, people might name them by most common elements, and for user-square that would be square and not user since it uses the same square as square but not the same user as user.

jmsv · 2023-10-26T20:28:41Z

One question, how do we decide if it should be user-square or square-user?

I reckon user-square makes more sense since the user is the main subject. There's also user-circle in a similar format.

Good point, pretty important part of the naming convention IMO.

Otherwise, people might name them by most common elements, and for user-square that would be square and not user since it uses the same square as square but not the same user as user.

Reckon this is something that should be included in the Naming conventions docs then? Happy to PR if so. Something like:

7. Names should start with the subject of the icon rather than any variant description.\
   For example: `user-square` instead of `square-user`

jmsv · 2023-10-26T20:29:57Z

Vercel build failed but I can't see why 🤔

Probably permission issue.

Looks like it yes – I get a 404. Do you have access to see what failed?

jmsv · 2023-10-27T16:54:43Z

Hmm, merged main and the new "Fail if contributors have changed" check is failing @jguddas

jguddas · 2023-10-27T18:09:18Z

Hmm, merged main and the new "Fail if contributors have changed" check is failing @jguddas

Good catch, #1643 is the fix.

…quare|circle) to (square|circle)-user* also as per Discord

jguddas

LGTM

karsa-mistmere · 2023-10-30T11:22:50Z

Nice work, @jmsv!

I'm piggybacking this PR to give the user-round icons a bit of a visual overhaul and some much needed optimization, as already discussed with @ericfennis and @jguddas on Discord. Our current icons were just far too small in comparison to other icons, the new layout allows for much better visual weight and better consistency within this set of icons.

I've also renamed user-*-square and user-*-circle to square-user-* and circle-user-* respectively, as these names are much less confusing and more semantically correct. In the future, we'll probably also add this naming scheme to our guidelines.

jmsv · 2023-10-30T11:30:40Z

Nice work, @jmsv!

I'm piggybacking this PR to give the user-round icons a bit of a visual overhaul and some much needed optimization, as already discussed with @ericfennis and @jguddas on Discord. Our current icons were just far too small in comparison to other icons, the new layout allows for much better visual weight and better consistency within this set of icons.

I've also renamed user-*-square and user-*-circle to square-user-* and circle-user-* respectively, as these names are much less confusing and more semantically correct. In the future, we'll probably also add this naming scheme to our guidelines.

Thanks @karsa-mistmere!

Ah okay cool, I thought we were going the the opposite (user-shape over shape-user) but I don't mind either way 😃

on Discord

Joined, can't find the discussion though – do you have a link/possible to tag me please?

karsa-mistmere · 2023-10-30T13:13:16Z

Joined, can't find the discussion though – do you have a link/possible to tag me please?

Oh, it was a private conversation in our maintainers' chat, sorry I wasn't clearer about this. 😅

Ah okay cool, I thought we were going the the opposite (user-shape over shape-user) but I don't mind either way 😃

We weren't quite sure either, and we do currently have a mix of both name formats, we're leaning more towards <shape>-<content> because in most scenarios the resulting names will end up a bit less confusing and more logically extensible:

some feel a bit funny, user-round-square ("What even is a round square?") and user-round-circle ("Aren't all circles round?")
should we ever have square-user-round-plus icon, this name would be a much more trivial extension of square-user-round than either user-round-plus-square or user-round-square-plus would be of user-round-square.

jmsv · 2023-11-01T11:40:27Z

Oh, it was a private conversation in our maintainers' chat, sorry I wasn't clearer about this. 😅

Ah ok! No problem

We weren't quite sure either, and we do currently have a mix of both name formats, we're leaning more towards <shape>-<content> because in most scenarios the resulting names will end up a bit less confusing and more logically extensible:

some feel a bit funny, user-round-square ("What even is a round square?") and user-round-circle ("Aren't all circles round?")

should we ever have square-user-round-plus icon, this name would be a much more trivial extension of square-user-round than either user-round-plus-square or user-round-square-plus would be of user-round-square.

Makes sense 👍

The updated user-round style looks great btw! 👌

Thanks for updating #1620 to match too

ericfennis

Great work @jmsv !!

jmsv · 2023-11-26T11:40:25Z

Great work @jmsv !!

Thanks for the merge! 🚀

I also have #1620 open, was waiting for this one to get merged first with the new user-round-* naming

* Renamed user-*-2 to user-round-* * Added user-round icon optimizations as per Discord + renamed user*-(square|circle) to (square|circle)-user* also as per Discord --------- Co-authored-by: Karsa <contact@karsa.org> Co-authored-by: Eric Fennis <eric.fennis@gmail.com>

Renamed user-*-2 to user-round-*

7dead4c

github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 26, 2023

Merge branch 'main' into rename/user-2-to-user-round

421d2c9

jmsv mentioned this pull request Oct 26, 2023

New icons: user-search and user-round-search #1620

Merged

23 tasks

vercel bot had a problem deploying to Preview October 26, 2023 19:36 Failure

jguddas approved these changes Oct 26, 2023

View reviewed changes

Merge branch 'main' into rename/user-2-to-user-round

a4cea8f

vercel bot deployed to Preview October 27, 2023 16:58 View deployment

Added user-round icon optimizations as per Discord + renamed user*-(s…

51c6e7d

…quare|circle) to (square|circle)-user* also as per Discord

jguddas approved these changes Oct 30, 2023

View reviewed changes

vercel bot deployed to Preview October 30, 2023 11:25 View deployment

karsa-mistmere approved these changes Oct 30, 2023

View reviewed changes

karsa-mistmere requested a review from ericfennis October 30, 2023 13:13

Merge branch 'main' into rename/user-2-to-user-round

437a757

vercel bot deployed to Preview November 24, 2023 10:27 View deployment

Merge branch 'main' into rename/user-2-to-user-round

2a50719

ericfennis approved these changes Nov 24, 2023

View reviewed changes

ericfennis merged commit 1a09e7f into lucide-icons:main Nov 24, 2023
5 checks passed

vercel bot deployed to Preview November 24, 2023 13:03 View deployment

jmsv deleted the rename/user-2-to-user-round branch November 26, 2023 11:22

karsa-mistmere mentioned this pull request Feb 11, 2024

Add radical icon (square root) #1847

Merged

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renamed user--2 to user-round- #1638

Renamed user--2 to user-round- #1638

jmsv commented Oct 26, 2023 •

edited

Loading

github-actions bot commented Oct 26, 2023 •

edited

Loading

jguddas left a comment

jguddas commented Oct 26, 2023

jmsv commented Oct 26, 2023

jmsv commented Oct 26, 2023

jguddas commented Oct 26, 2023

jguddas commented Oct 26, 2023

jmsv commented Oct 26, 2023

jmsv commented Oct 26, 2023

jmsv commented Oct 27, 2023

jguddas commented Oct 27, 2023

jguddas left a comment

karsa-mistmere commented Oct 30, 2023

jmsv commented Oct 30, 2023

karsa-mistmere commented Oct 30, 2023

jmsv commented Nov 1, 2023

ericfennis left a comment

jmsv commented Nov 26, 2023

Renamed user-*-2 to user-round-* #1638

Renamed user-*-2 to user-round-* #1638

Conversation

jmsv commented Oct 26, 2023 • edited Loading

What is the purpose of this pull request?

Description

github-actions bot commented Oct 26, 2023 • edited Loading

Added or changed icons

jguddas left a comment

Choose a reason for hiding this comment

jguddas commented Oct 26, 2023

jmsv commented Oct 26, 2023

jmsv commented Oct 26, 2023

jguddas commented Oct 26, 2023

jguddas commented Oct 26, 2023

jmsv commented Oct 26, 2023

jmsv commented Oct 26, 2023

jmsv commented Oct 27, 2023

jguddas commented Oct 27, 2023

jguddas left a comment

Choose a reason for hiding this comment

karsa-mistmere commented Oct 30, 2023

jmsv commented Oct 30, 2023

karsa-mistmere commented Oct 30, 2023

jmsv commented Nov 1, 2023

ericfennis left a comment

Choose a reason for hiding this comment

jmsv commented Nov 26, 2023

Renamed user--2 to user-round- #1638

Renamed user--2 to user-round- #1638

jmsv commented Oct 26, 2023 •

edited

Loading

github-actions bot commented Oct 26, 2023 •

edited

Loading