New icons: user-search and user-round-search

[jmsv]

What is the purpose of this pull request?

• New Icon
• Bug fix
• New Feature
• Documentation update
• Other:

Description

New icons:

• user-search
• user-search-2

Icon use case

• Searching for users
• Recruitment

Alternative icon designs

Icon Design Checklist

Concept

• I have provided valid use cases for each icon.
• I have not added any a brand or logo icon.
• I have not used any hate symbols.
• I have not included any religious or political imagery.

Author, credits & license

• The icons are solely my own creation.
• The icons were originally created in # by @
• I've based them on the following Lucide icons: user-check, user-plus, user-x etc. + corresponding -2 variations, plus search
• I've based them on the following design:

Naming

• I've read and followed the naming conventions
• I've named icons by what they are rather than their use case.
• I've provided meta JSON files in icons/[iconName].json.

Design

• I've read and followed the icon design guidelines
• I've made sure that the icons look sharp on low DPI displays.
• I've made sure that the icons look consistent with the icon set in size, optical volume and density.
• I've made sure that the icons are visually centered.
• I've correctly optimized all icons to two points of precision.

Before Submitting

• I've read the Contribution Guidelines.
• I've checked if there was an existing PR that solves the same issue.

[github-actions]

Added or changed icons

Preview cohesion

Preview stroke widths

DPI Preview (24px)

Icon X-rays

[jguddas]

https://lucide-site-git-feat-added-edit-page-jguddas.vercel.app/edit?PHN2ZwogIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIKICB3aWR0aD0iMjQiCiAgaGVpZ2h0PSIyNCIKICB2aWV3Qm94PSIwIDAgMjQgMjQiCiAgZmlsbD0ibm9uZSIKICBzdHJva2U9ImN1cnJlbnRDb2xvciIKICBzdHJva2Utd2lkdGg9IjIiCiAgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIgogIHN0cm9rZS1saW5lam9pbj0icm91bmQiCj4KICA8Y2lyY2xlIGN4PSIxMCIgY3k9IjciIHI9IjQiIC8+CiAgPGNpcmNsZSBjeD0iMTciIGN5PSIxNyIgcj0iMyIgLz4KICA8cGF0aCBkPSJtMjEgMjEtMS45LTEuOSIgLz4KICA8cGF0aCBkPSJNMTAuMyAxNUg3YTQgNCAwIDAgMC00IDR2MiIgLz4KPC9zdmc+=

[jmsv]

@jguddas that looks good, did that exist somewhere already? missed it if so

had a go at making a similar version for the user-2 style:

[jmsv]

updated this PR with the new icons, looks much better, thanks for having a look!

[jguddas]

It's based on an existing icon, so it should inherit the contributors.

[jmsv]

It's based on an existing icon, so it should inherit the contributors.

gotcha, missed that – fixed

[jguddas]

user-search-2 violates naming guidelines, icons should not end with -2.

I highly recommend creating one PR per icon.

[karsa-mistmere]

user-search-2 violates naming guidelines, icons should not end with -2.

Yes, but all our user*-2 icons violate this naming guideline, so it's not @jmsv's fault, strictly speaking.

All these names should be fixed, I agree, but while they're not, using the same naming scheme is preferable to deviating from it. I'm voting for user-round-*, but I do really feel that this is a separate issue.

[jguddas]

IMO adding icons with the same use case but with different styles is something we should avoid, it works against having one consistent feel across all icons.

So 👍 for user-search and 👎 for user-search-2 from me.

[jmsv]

Thanks for having a look @jguddas and @karsa-mistmere ❤️

---

I highly recommend creating one PR per icon.

From CONTRIBUTING.md:

If you want submit multiple icons, please separate the icons and group them. That makes reviewing the icons easier and keep the thread clean and scoped. So don't submit multiple icons in one PR that have noting to do with each other. So for example don't create one PR with icons: arrow-up, bicycle, arrow-down. Seperate them by two PRs; 'pr-01' arrow, arrow-down and 'pr-02' bicycle.

As-per these guidelines I think I was correct in making this one PR.

---

Re the user*-2 naming I'm aware that the Naming conventions advise against -2 for "what makes the alternate unique" but I opted for naming consistency instead – I agree with @karsa-mistmere that it makes more sense than deviating.

I like the sound of user-round-*! Should take into account though that this would be a breaking change for anyone currently using user*-2 icons.

---

As for what to do with this PR, it looks like the options are:

1. Keep the user-search-2 name for now
2. Rename user-search-2 to user-round-search
3. Remove user-search-2 entirely

Option 2 isn't ideal since it introduces naming inconsistency, and option 3 isn't ideal since it also introduces inconsistency considering every other user-* icon has a -2 variant.

Hoping we can go with option 1 but let me know what you think

[karsa-mistmere]

We can add backwards compatible aliases for current user-*-2 icons.

[jmsv]

We can add backwards compatible aliases for current user-*-2 icons.

Ah, awesome! I'd be happy to have a go at setting that up

[jguddas]

We can add backwards compatible aliases for current user-*-2 icons.

Ah, awesome! I'd be happy to have a go at setting that up

If you are up for it, you can give my new renameIcon.sh script a try.

#1630

How to use it

Make sure you have the gh cli installed.

Don't think this will work on Windows.

gh pr checkout 1630 # go to my PR with the new rename script
./scripts/renameIcon.sh user-2 user-round # run the script
git checkout main # go back to main
git checkout -b rename/user-2-to-user-round # create a new branch
git commit -m 'Renamed user-2 to user-round' # commit the changes
gh pr create --title 'Renamed user-2 to user-round' # create a pull request
git checkout main # go back to main

[jmsv]

Done! #1638

Probably makes sense to get that one merged first and then I'll update this PR to rename user-search-2 to user-round-search