Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added renameIcon script #1630

Merged
merged 8 commits into from
Dec 16, 2023

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Oct 22, 2023

Examples:
#1629
#1628

@jguddas
Copy link
Member Author

jguddas commented Oct 26, 2023

sh or mjs, what is better?

@jmsv
Copy link
Contributor

jmsv commented Oct 26, 2023

sh or mjs, what is better?

I'd go for mjs because it's OS-agnostic, consistent with other lucide scripts, and (imo at least) it's easier to work with, especially for more complex stuff

For example it'd be cool if this script could handle regex replace. Would be helpful for renaming lots of things with similar names, e.g. all of the user*-2 icons as-discussed in #1620

Also in this case the sh depends on jq being installed but the mjs only depends on simple-git which is already in devDependencies

@jmsv jmsv mentioned this pull request Oct 26, 2023
7 tasks
@jguddas jguddas marked this pull request as draft October 26, 2023 21:05
@jguddas jguddas marked this pull request as ready for review October 27, 2023 18:29
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice script!
I think we can also add this to the package.json scripts.

We should also add a documentation section in the contribution guidelines about this line.

Copy link

github-actions bot commented Dec 1, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 1, 2023
@ericfennis ericfennis merged commit e7abba5 into lucide-icons:main Dec 16, 2023
1 check passed
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
* feat: added renameIcon script

* feat: added renameIcon script

* chore: converted renameIcon.sh to mjs

* refactor: cleanup

* Delete scripts/renameIcon.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants