-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ena-submission): Parse get analysis process response better for single segment case, return partial results and submit projects with holdUntilDate #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-parker
force-pushed
the
patch_create_assembly
branch
from
September 29, 2024 13:10
02f5298
to
4a23af1
Compare
anna-parker
commented
Sep 29, 2024
anna-parker
changed the title
Update to allow for receiving only gca or insdc accessions, fix case …
fix(ena-submission): Parse get analysis process response better for single segment case, return partial results and submit projects with holdUntilDate
Sep 29, 2024
corneliusroemer
approved these changes
Sep 30, 2024
…for single segmented viruses
corneliusroemer
force-pushed
the
patch_create_assembly
branch
from
September 30, 2024 14:29
39bfd4e
to
6349c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2895
preview URL: https://patch-create-assembly.loculus.org/
Summary
Note that chromosome accessions are the accessions of the nucleotides in each submitted segment, in PP we call this insdcAccession_{segment}.
This PR additionally modifies the project submission request to by default submit projects with a
hold_until_date
parameter which is set to the day of submission (as we anyways only submit data to ENA when it is OPEN we should make the project public).Screenshot
Testing
Tested on preview by
ERZ24784470
, confirm this leads to state SUBMITTED: