Skip to content

Commit

Permalink
improve name
Browse files Browse the repository at this point in the history
  • Loading branch information
anna-parker committed Sep 28, 2024
1 parent da3faff commit 02f5298
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions ena-submission/scripts/ena_submission_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def get_ena_analysis_process(
)
insdc_accession_range = acc_dict.get("chromosomes")
if insdc_accession_range:
chromosome_accessions_dict = get_chromsome_assemblies(
chromosome_accessions_dict = get_chromsome_accessions(
insdc_accession_range, segment_order
)
assembly_results.update(chromosome_accessions_dict)
Expand All @@ -431,7 +431,7 @@ def get_ena_analysis_process(
return CreationResults(results=assembly_results, errors=errors, warnings=warnings)


def get_chromsome_assemblies(insdc_accession_range: str, segment_order: list[str]):
def get_chromsome_accessions(insdc_accession_range: str, segment_order: list[str]):
results = {}
start_letters = insdc_accession_range.split("-")[0][:2]
start_digit = 10 ** (
Expand Down
12 changes: 6 additions & 6 deletions ena-submission/scripts/test_ena_submission.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
create_fasta,
create_manifest,
dataclass_to_xml,
get_chromsome_assemblies,
get_chromsome_accessions,
)
from ena_types import default_project_type, default_sample_type
from requests import exceptions
Expand Down Expand Up @@ -268,10 +268,10 @@ def test_create_manifest(self):

self.assertEqual(data, expected_data)

def test_get_chromsome_assemblies(self):
def test_get_chromsome_accessions(self):
insdc_accession_range = "OZ189935-OZ189936"
segment_order = ["seg2", "seg3"]
result_multi = get_chromsome_assemblies(insdc_accession_range, segment_order)
result_multi = get_chromsome_accessions(insdc_accession_range, segment_order)
self.assertEqual(
result_multi,
{
Expand All @@ -283,7 +283,7 @@ def test_get_chromsome_assemblies(self):
)
insdc_accession_range = "OZ189935-OZ189935"
segment_order = ["main"]
result_single = get_chromsome_assemblies(insdc_accession_range, segment_order)
result_single = get_chromsome_accessions(insdc_accession_range, segment_order)
self.assertEqual(
result_single,
{
Expand All @@ -293,7 +293,7 @@ def test_get_chromsome_assemblies(self):
)
insdc_accession_range = "OZ189935-OZ189935"
segment_order = ["seg3"]
result_single = get_chromsome_assemblies(insdc_accession_range, segment_order)
result_single = get_chromsome_accessions(insdc_accession_range, segment_order)
self.assertEqual(
result_single,
{
Expand All @@ -304,7 +304,7 @@ def test_get_chromsome_assemblies(self):
insdc_accession_range = "OZ189935-OZ189936"
segment_order = ["main"]
with self.assertRaises(requests.exceptions.RequestException):
get_chromsome_assemblies(insdc_accession_range, segment_order)
get_chromsome_accessions(insdc_accession_range, segment_order)


if __name__ == "__main__":
Expand Down

0 comments on commit 02f5298

Please sign in to comment.