Drupal 11 support #262
Merged
Drupal 11 support #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any reason this shouldn't come out of draft? Figure if we can get this in it unblocks a bunch of others? |
Member
|
Guess what |
Member
|
I'm still seeing lots of |
…reEventDispatcher
ekes
force-pushed
the
fix/2.x/246-drupal-11-support
branch
from
7d94100 to
e0457ad
Compare
Member
|
OK That was possibly a bit too much but worked, got rid of all the |
Merged
ekes
added a commit
that referenced
this pull request
Feb 4, 2025
* Drupal 11 support (#262) Note: Allows linkit to upgrade to 7.0 * Declare Drupal 11 support #246 * feat: update linkit to recommended version * Add D11 tests workflow. * fix: update test module drupal core requirements * fix: should take an EventDispatcherInterface object, not ContainerAwareEventDispatcher * Patch for nullable types warning. * Patch for nullable types. * Workflows was merged into main. * Allow upgrading linkit to 7.0 but keep 6.1 for dependencies. Will drop 6.1 is next release. * Linkit has released a version with the nullable types patch. * Make module enable test something. New D11 phpunit tests fail if no assertion. --------- Co-authored-by: Lee Mills <lee@leemills.dev> Co-authored-by: ekes <ekes@iskra.net> * Add a view display extender for the localgov_page_header for the lede (#257) * Add a view display extender for the localgov_page_header for the lede Fix #127 Adds a setting to views that allows for a page header category, with the option to set a custom lede inside the view, which will then be used by the page header block. * Correct page header display extender title * Add seperate view property with setter and getter to pageHeaderDisplayEvent Since a viewExecutable is not a child of EntityInterface, provide seperate $view property and set that when viewing a view page from the pageHeaderBlock. * Add comment on why $view has to be rendered and cs fixes * Fix create docblock event in views display extender * Add views as dependency as pageDisplayExtender requires it * Enable the views page header display extender by default - Enables by default and adds update hook. - Removes the install from the test. * Fix missing return type errors --------- Co-authored-by: Stephen Cox <stephen-cox@users.noreply.github.com> Co-authored-by: Lee Mills <lee@leemills.dev> Co-authored-by: Andy Broomfield <andy.broomfield@brighton-hove.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246
Currently fails because we require drupal/linkit ^7.0 (latest recommended version) but this also needs to be bumped in localgov_page_components at the same time