Skip to content

Conversation

@ekes
Copy link
Member

@ekes ekes commented Feb 4, 2025

Drupal 11 support (#262)

Note: Allows linkit to upgrade to 7.0

Note: Allows linkit to upgrade to 7.0

* Declare Drupal 11 support #246
* feat: update linkit to recommended version
* Add D11 tests workflow.
* fix: update test module drupal core requirements
* fix: should take an EventDispatcherInterface object, not ContainerAwareEventDispatcher
* Patch for nullable types warning.
* Patch for nullable types.
* Workflows was merged into main.
* Allow upgrading linkit to 7.0 but keep 6.1 for dependencies.
Will drop 6.1 is next release.
* Linkit has released a version with the nullable types patch.
* Make module enable test something. New D11 phpunit tests fail if no assertion.

---------

Co-authored-by: Lee Mills <lee@leemills.dev>
Co-authored-by: ekes <ekes@iskra.net>
@ekes ekes requested a review from stephen-cox February 4, 2025 09:48
…#257)

* Add a view display extender for the localgov_page_header for the lede

Fix #127

Adds a setting to views that allows for a page header category, with the option
to set a custom lede inside the view, which will then be used by the
page header block.

* Correct page header display extender title

* Add seperate view property with setter and getter to pageHeaderDisplayEvent

Since a viewExecutable is not a child of EntityInterface, provide seperate
$view property and set that when viewing a view page from the pageHeaderBlock.

* Add comment on why $view has to be rendered and cs fixes

* Fix create docblock event in views display extender

* Add views as dependency as pageDisplayExtender requires it

* Enable the views page header display extender by default

- Enables by default and adds update hook.
- Removes the install from the test.

* Fix missing return type errors
@ekes ekes merged commit a58e672 into release-2.x Feb 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants