[Meta] Drupal 11 support

[stephen-cox]

Update: Closing in favour of drupal.org issue at https://www.drupal.org/project/localgov/issues/3566368 for remaining tasks

---

Creating this as a meta issue to track Drupal 11 support.

As discussed at Merge Tuesday, we need to get an idea of how big a job fully supporting Drupal 11 will be. Hopefully, the code should largely support D11 now, so this is likely largely come down to checking contrib support.

Current state of Drupal 11 support:

Dependencies without Drupal 11 support:

• https://www.drupal.org/project/autocomplete_deluxe added in 2.10
• https://www.drupal.org/project/fontawesome added in 3.0.0
• https://www.drupal.org/project/geo_entity added in 1.0.2
• https://www.drupal.org/project/image_widget_crop currently only in dev
• https://www.drupal.org/project/office_hours added in 1.19
• https://www.drupal.org/project/role_delegation added in 8.x-1.3
• https://www.drupal.org/project/search_api_location added in 8.x-1.0-alpha4
• https://www.drupal.org/project/social_post added in 3.0.2
• https://www.drupal.org/project/social_post_twitter
• https://www.drupal.org/project/tablefield added in 3.0.0-beta1
• https://www.drupal.org/project/views_field_view added in 8.x-1.0-beta6
• https://www.drupal.org/project/webform added in 6.3.0-alpha2
• https://www.drupal.org/project/group (dev dependency on a few modules e.g. alert banner) - added in 3.3.0
• https://www.drupal.org/project/facets_form (dependency of directories) - added in 1.2.0

Also see https://docs.google.com/spreadsheets/d/1QVDrKtLI1KuAeMfZRQpn0O7nCRX7w7fo0StFHXP58g8/edit?gid=0#gid=0

Issues:

• Add Drupal 11 support to profile #766
• Drupal 11 support localgov_alert_banner#334
• Drupal 11 support localgov_blogs#39
• Drupal 11 support localgov_core#246
• Drupal 11 support localgov_directories#394
• Drupal 11 support localgov_elections#130
• Drupal 11 support localgov_events#158
• Drupal 11 support localgov_forms#90
• Drupal 11 support localgov_guides#177
• Drupal 11 support localgov_news#122
• Drupal 11 support localgov_openreferral#56
• Drupal 11 support localgov_page_components#59
• Drupal 11 support localgov_paragraphs#193
• Drupal 11 support localgov_search#76
• Drupal 11 support localgov_search_solr#20
• Drupal 11 support localgov_services#280
• Drupal 11 support localgov_step_by_step#114
• Drupal 11 support localgov_subsites#158
• Drupal 11 support localgov_workflows#114

PRs:

• Declare Drupal 11 support localgov_claro#23
• Mark support for Drupal 11 and drop Drupal 9 localgov_demo#139
• Mark support for Drupal 11 and drop Drupal 9 localgov_events#157
• Mark support for Drupal 11 and drop Drupal 9 localgov_geo#130
• feat: support Drupal 11 localgov_menu_link_group#42
• feat: support Drupal 11 localgov_netcall#6
• Add Drupal 11 support localgov_page#56
• Add Drupal 11 support localgov_sa11y#37
• feat: support Drupal 11 localgov_search#77
• feat: support Drupal 11 localgov_search_solr#21
• feat: support Drupal 11 localgov_subsites_extras#35
• Add Drupal 11 support localgov_topics#31
• Drupal 11 support localgov_core#262
• Drupal 11 support localgov_directories#408
• D11 compatibility and Coding Standards fixes. localgov_openreferral#59

[stephen-cox]

@millnut I believe you have started this. Can you add an update on how far you've got with this?

I'll find some time to look at this, but I don't want to duplicate work that has been done so far.

[millnut]

Yep sure I've got all this compiled and should be able to post something for discussion.

As you mentioned @stephen-cox the biggest problem is where contrib modules have two versions, one for D10 and one for D11

[millnut]

@stephen-cox I've added a 4.x branch for the project which set drupal core to 11 and updates the workflow for just 4.x requirements https://github.com/localgovdrupal/localgov_project/tree/4.x I'm expecting this to fail to start with

[millnut]

@stephen-cox here is the file I've been looking at with notes on contrib module changes
https://docs.google.com/spreadsheets/d/1QVDrKtLI1KuAeMfZRQpn0O7nCRX7w7fo0StFHXP58g8/edit?usp=sharing be good if we can upload to Google Docs so we can collab on it

[stephen-cox]

Thanks @millnut for the spreadsheet.

Looking at this it looks like the main D11 upgrade is blocked by the following contrib modules:

• image_widget_crop - require by core.
• role_delegation - required by core.
• fontawesome - require by paragraphs.
• office_hours - required by paragraphs.
• tablefield - required by paragraphs.
• search_api_location - required by directories.

There are other contrib dependencies blocking upgrades to some of the other modules, but these are included by default.

We either need to wait for D11 support to be added to these modules or agree a workaround for them.

[millnut]

Thanks for looking through @stephen-cox I might look at contributing some patches on drupal.org for those and see if they get picked up

[markconroy]

Acquia have a portal here to show the status of all modules.

https://dev.acquia.com/drupal11/deprecation_status/projects

Here's the modules we are waiting for: https://dev.acquia.com/drupal11/deprecation_status/projects?names=image_widget_crop%2C%20role_delegation%2C%20fontawesome%2C%20office_hours%2C%20tablefield%2C%20search_api_location

[stephen-cox]

Looks like we're now waiting for Drupal 11 support in:

• fontawesome
• office_hours
• tablefield

All required by paragraphs.

[millnut]

I have updated the first post and the spreadsheet with the latest contrib module compatibility

[millnut]

Existing installs using composer aliases for D11 support is making progress and composer installs work (see localgovdrupal/localgov_shared_workflows#19 (comment)) just need to update our modules and wait for fontawesome and image_widget_crop to tag releases as these are the main blockers. For testing we are blocked waiting for a new release of caxy/php-htmldiff but that is specifically for PHP 8.4 testing (have patched for now).

Composer aliases so far;

"localgovdrupal/localgov"
"localgovdrupal/localgov_core"
"localgovdrupal/localgov_demo"
"localgovdrupal/localgov_directories"
"localgovdrupal/localgov_events"
"localgovdrupal/localgov_geo"
"localgovdrupal/localgov_guides"
"localgovdrupal/localgov_news"
"localgovdrupal/localgov_page_components"
"localgovdrupal/localgov_paragraphs"
"localgovdrupal/localgov_services"
"localgovdrupal/localgov_step_by_step"
"localgovdrupal/localgov_subsites"
"localgovdrupal/localgov_workflows"

The remaining one is uninstalled by default but part of core is localgov_openreferral which needs quite a bit of work. Who maintains this one now?

We can start reviewing these WIP D11 PRs, merging, and creating releases on low-impact ones.

New/Clean installs and installs via Drush there is still some work to do on module core version compatibility as well as the contrib modules above.

[millnut]

fontawesome should have a release soon it went to the project update working group https://www.drupal.org/project/puwg/issues/3498021 for a chase on D11 release date

[millnut]

I've contacted a maintainer of image_widget_crop on rough ETA for a D11 compatible tagged version

[millnut]

@ekes @stephen-cox directories is blocked for D11 by drupal/facets_form which doesn't have a D11 release will add to the list

[andybroomfield]

Facets form has a D11 fix here https://www.drupal.org/project/facets_form/issues/3455218 (labbled as needs review)
As its a dev only dependency (to run tests with the facets form plugin) maybe a case to use Drupal lienient and patch? to get tests to pass?