[Sanitizer] Fix android test env issue #142235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Ellis Hoag (ellishg) ChangesI attempted to fix android tests in #142207 (broken by #141820). They are still failing but now I have more info. https://lab.llvm.org/buildbot/#/builders/186/builds/9504/steps/16/logs/stdio ERROR: Can't open file: //foo.8862 (reason: 30) I believe the reason is that on android the HOME and TMPDIR environment variables are not being set correctly, or they are not read correctly. (#142234 (comment)) Also remove an extra %env left in a related test. Full diff: https://github.com/llvm/llvm-project/pull/142235.diff 2 Files Affected:
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
index 782cd0218fd22..af5187a0d3265 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
@@ -1,10 +1,10 @@
// RUN: %clangxx -O2 %s -o %t
// Case 1: Try setting a path that is an invalid/inaccessible directory.
-// RUN: not %env %run %t 2>&1 | FileCheck %s --check-prefix=ERROR1
+// RUN: not %run %t 2>&1 | FileCheck %s --check-prefix=ERROR1
// Case 2: Try setting a path that is too large.
-// RUN: not %env %run %t A 2>&1 | FileCheck %s --check-prefix=ERROR2
+// RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=ERROR2
#include <sanitizer/common_interface_defs.h>
#include <stdio.h>
diff --git a/compiler-rt/test/sanitizer_common/android_commands/android_run.py b/compiler-rt/test/sanitizer_common/android_commands/android_run.py
index f50fc1eb2540d..3f41ce4447dcf 100755
--- a/compiler-rt/test/sanitizer_common/android_commands/android_run.py
+++ b/compiler-rt/test/sanitizer_common/android_commands/android_run.py
@@ -13,7 +13,7 @@ def build_env():
# Android linker ignores RPATH. Set LD_LIBRARY_PATH to Output dir.
args.append("LD_LIBRARY_PATH=%s" % (ANDROID_TMPDIR,))
for (key, value) in list(os.environ.items()):
- if key in ["ASAN_ACTIVATION_OPTIONS", "SCUDO_OPTIONS"] or key.endswith(
+ if key in ["ASAN_ACTIVATION_OPTIONS", "SCUDO_OPTIONS", "HOME", "TMPDIR"] or key.endswith(
"SAN_OPTIONS"
):
args.append('%s="%s"' % (key, value.replace('"', '\\"')))
|
fmayer
approved these changes
May 30, 2025
|
✅ With the latest revision this PR passed the Python code formatter. |
teresajohnson
approved these changes
May 30, 2025
ellishg
added a commit
that referenced
this pull request
May 31, 2025
I attempted to fix this test in #142235 but we a new error. https://lab.llvm.org/buildbot/#/builders/186/builds/9524/steps/26/logs/stdio > ERROR: Can't create directory: /var The path we want is actually at `/data/local/tmp/Output/var/...`. I found `%device_rundir/` evaluates to this prefix on android, and nothing otherwise. https://github.com/llvm/llvm-project/blob/f057a593a7151437edd25cfbbdcf450139346f12/compiler-rt/test/lit.common.cfg.py#L658
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 31, 2025
I attempted to fix this test in llvm/llvm-project#142235 but we a new error. https://lab.llvm.org/buildbot/#/builders/186/builds/9524/steps/26/logs/stdio > ERROR: Can't create directory: /var The path we want is actually at `/data/local/tmp/Output/var/...`. I found `%device_rundir/` evaluates to this prefix on android, and nothing otherwise. https://github.com/llvm/llvm-project/blob/f057a593a7151437edd25cfbbdcf450139346f12/compiler-rt/test/lit.common.cfg.py#L658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to fix android tests in #142207 (broken by #141820). They are still failing but now I have more info.
https://lab.llvm.org/buildbot/#/builders/186/builds/9504/steps/16/logs/stdio
ERROR: Can't open file: //foo.8862 (reason: 30)
I believe the reason is that on android the HOME and TMPDIR environment variables are not being set correctly, or they are not read correctly. (#142234 (comment))