[Sanitizer][test] Emit to stderr to fix android #142207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Ellis Hoag (ellishg) ChangesThis test is broken on android by #141820 https://lab.llvm.org/buildbot/#/builders/186/builds/9498 > FileCheck error: '' is empty. I suspect that on android printf only works if its emitted to stderr because this use to work Only emit to stderr and see if that fixes the test. Full diff: https://github.com/llvm/llvm-project/pull/142207.diff 1 Files Affected:
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
index 9d7ed80b44ccb..8abd476708b4c 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
@@ -1,7 +1,6 @@
// Test __sanitizer_set_report_path and __sanitizer_get_report_path:
// RUN: %clangxx -O2 %s -o %t
-// RUN: %env HOME=%t.homedir TMPDIR=%t.tmpdir %run %t 2>%t.err | FileCheck %s
-// RUN: FileCheck %s --input-file=%t.err --check-prefix=ERROR
+// RUN: %env HOME=%t.homedir TMPDIR=%t.tmpdir %run %t 2>&1 | FileCheck %s
#include <sanitizer/common_interface_defs.h>
#include <stdio.h>
@@ -12,31 +11,31 @@ int main(int argc, char **argv) {
sprintf(buff, "%s.report_path/report", argv[0]);
__sanitizer_set_report_path(buff);
// CHECK: {{.*}}.report_path/report.[[PID:[0-9]+]]
- printf("%s\n", __sanitizer_get_report_path());
+ fprintf(stderr, "%s\n", __sanitizer_get_report_path());
strcpy(buff, "%H/foo");
__sanitizer_set_report_path(buff);
// CHECK: [[T:.*]].homedir/foo.[[PID]]
- printf("%s\n", __sanitizer_get_report_path());
+ fprintf(stderr, "%s\n", __sanitizer_get_report_path());
strcpy(buff, "%t/foo");
__sanitizer_set_report_path(buff);
// CHECK: [[T]].tmpdir/foo.[[PID]]
- printf("%s\n", __sanitizer_get_report_path());
+ fprintf(stderr, "%s\n", __sanitizer_get_report_path());
strcpy(buff, "%H/%p/%%foo");
__sanitizer_set_report_path(buff);
// CHECK: [[T]].homedir/[[PID]]/%foo.[[PID]]
- printf("%s\n", __sanitizer_get_report_path());
+ fprintf(stderr, "%s\n", __sanitizer_get_report_path());
strcpy(buff, "%%foo%%bar");
__sanitizer_set_report_path(buff);
// CHECK: %foo%bar.[[PID]]
- printf("%s\n", __sanitizer_get_report_path());
+ fprintf(stderr, "%s\n", __sanitizer_get_report_path());
strcpy(buff, "%%foo%ba%%r");
__sanitizer_set_report_path(buff);
- // ERROR: Unexpected pattern: %%foo%ba%%r
+ // CHECK: Unexpected pattern: %%foo%ba%%r
// CHECK: %%foo%ba%%r.[[PID]]
- printf("%s\n", __sanitizer_get_report_path());
+ fprintf(stderr, "%s\n", __sanitizer_get_report_path());
}
|
teresajohnson
approved these changes
May 30, 2025
fmayer
approved these changes
May 30, 2025
This was referenced May 30, 2025
ellishg
added a commit
that referenced
this pull request
May 31, 2025
I attempted to fix android tests in #142207 (broken by #141820). They are still failing but now I have more info. https://lab.llvm.org/buildbot/#/builders/186/builds/9504/steps/16/logs/stdio ERROR: Can't open file: //foo.8862 (reason: 30) I believe the reason is that on android the HOME and TMPDIR environment variables are not being set correctly, or they are not read correctly. (#142234 (comment))
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 31, 2025
I attempted to fix android tests in llvm/llvm-project#142207 (broken by llvm/llvm-project#141820). They are still failing but now I have more info. https://lab.llvm.org/buildbot/#/builders/186/builds/9504/steps/16/logs/stdio ERROR: Can't open file: //foo.8862 (reason: 30) I believe the reason is that on android the HOME and TMPDIR environment variables are not being set correctly, or they are not read correctly. (llvm/llvm-project#142234 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is broken on android by #141820
https://lab.llvm.org/buildbot/#/builders/186/builds/9498
I suspect that on android printf only works if its emitted to stderr because this use to work
llvm-project/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
Lines 21 to 22 in a2ce564
Only emit to stderr and see if that fixes the test.