[AArch64] Update __gcsss intrinsic to match revised ACLE specification #136850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-clang Author: SivanShani-Arm (sivan-shani) ChangesThe original __gcsss intrinsic was implemented based on: ARM-software/acle#260 Per the updated specification in: This aligns the implementation with the latest ACLE definition. Full diff: https://github.com/llvm/llvm-project/pull/136850.diff 1 Files Affected:
diff --git a/clang/lib/Headers/arm_acle.h b/clang/lib/Headers/arm_acle.h
index 89db5dc2d7aaa..7681a8e9d2985 100644
--- a/clang/lib/Headers/arm_acle.h
+++ b/clang/lib/Headers/arm_acle.h
@@ -841,8 +841,9 @@ __gcspopm() {
return __builtin_arm_gcspopm(0);
}
-static __inline__ const void * __attribute__((__always_inline__, __nodebug__, target("gcs")))
-__gcsss(const void *__stack) {
+static __inline__ void *
+ __attribute__((__always_inline__, __nodebug__, target("gcs")))
+ __gcsss(void *__stack) {
return __builtin_arm_gcsss(__stack);
}
#endif
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
llvmbot
added
backend:AArch64
clang:frontend
|
I think clang/test/CodeGen/AArch64/gcs.c should also be updated (this PR doesn't cause it to fail, but it does mean it has a warning about discarded const qualifier, and it would be better not to have that). |
|
clang/test/CodeGen/AArch64/gcs.c updated |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
llvm#136850) The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
llvm#136850) The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
llvm#136850) The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
llvm#136850) The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original __gcsss intrinsic was implemented based on: ARM-software/acle#260
with the signature: const void *__gcsss(const void *)
Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *)
This aligns the implementation with the latest ACLE definition.