[doc] Use ISO nomenclature for 1024 byte units #133148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
llvmbot
added
lld
lldb
backend:X86
lld:ELF
openmp:libomp
|
@llvm/pr-subscribers-lldb @llvm/pr-subscribers-backend-x86 Author: Alexander Ziaee (concussious) ChangesIncrease specificity by using the correct unit sizes. KBytes is an abbreviation for kB, 1000 bytes, and the hardware industry as well as several operating systems have now switched to using 1000 byte kBs. If this change is acceptable, sometimes GitHub mangles merges to use the original email of the account. $dayjob asks contributions have my work email. Thanks! Full diff: https://github.com/llvm/llvm-project/pull/133148.diff 5 Files Affected:
diff --git a/lld/ELF/Relocations.cpp b/lld/ELF/Relocations.cpp
index 629702b45965b..0653f79890646 100644
--- a/lld/ELF/Relocations.cpp
+++ b/lld/ELF/Relocations.cpp
@@ -162,7 +162,7 @@ static RelType getMipsPairType(RelType type, bool isLocal) {
// symbol, the R_MIPS_GOT16 relocation creates a GOT entry to hold
// the high 16 bits of the symbol's value. A paired R_MIPS_LO16
// relocations handle low 16 bits of the address. That allows
- // to allocate only one GOT entry for every 64 KBytes of local data.
+ // to allocate only one GOT entry for every 64 KiB of local data.
return isLocal ? R_MIPS_LO16 : R_MIPS_NONE;
case R_MICROMIPS_GOT16:
return isLocal ? R_MICROMIPS_LO16 : R_MIPS_NONE;
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
index 67ba42f33d1dd..4a1117222f34c 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
@@ -1377,7 +1377,7 @@ GDBRemoteCommunicationServerCommon::GetModuleInfo(llvm::StringRef module_path,
std::vector<std::string> GDBRemoteCommunicationServerCommon::HandleFeatures(
const llvm::ArrayRef<llvm::StringRef> client_features) {
- // 128KBytes is a reasonable max packet size--debugger can always use less.
+ // 128 KiB is a reasonable max packet size--debugger can always use less.
constexpr uint32_t max_packet_size = 128 * 1024;
// Features common to platform server and llgs.
diff --git a/lldb/tools/debugserver/source/RNBRemote.cpp b/lldb/tools/debugserver/source/RNBRemote.cpp
index eb7c5ca32c02a..2ff4f29101f44 100644
--- a/lldb/tools/debugserver/source/RNBRemote.cpp
+++ b/lldb/tools/debugserver/source/RNBRemote.cpp
@@ -3477,7 +3477,7 @@ static bool GetProcessNameFrom_vAttach(const char *&p,
}
rnb_err_t RNBRemote::HandlePacket_qSupported(const char *p) {
- uint32_t max_packet_size = 128 * 1024; // 128KBytes is a reasonable max packet
+ uint32_t max_packet_size = 128 * 1024; // 128 KiB is a reasonable max packet
// size--debugger can always use less
std::stringstream reply;
reply << "qXfer:features:read+;PacketSize=" << std::hex << max_packet_size
diff --git a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
index 8bee87a22db16..fb91884d40132 100644
--- a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
+++ b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
@@ -122,7 +122,7 @@ std::optional<unsigned> X86TTIImpl::getCacheSize(
// - Broadwell
// - Skylake
// - Kabylake
- return 32 * 1024; // 32 KByte
+ return 32 * 1024; // 32 KiB
case TargetTransformInfo::CacheLevel::L2D:
// - Penryn
// - Nehalem
@@ -133,7 +133,7 @@ std::optional<unsigned> X86TTIImpl::getCacheSize(
// - Broadwell
// - Skylake
// - Kabylake
- return 256 * 1024; // 256 KByte
+ return 256 * 1024; // 256 KiB
}
llvm_unreachable("Unknown TargetTransformInfo::CacheLevel");
diff --git a/openmp/tools/archer/ompt-tsan.cpp b/openmp/tools/archer/ompt-tsan.cpp
index bb60fc6b603f4..c315999af4328 100644
--- a/openmp/tools/archer/ompt-tsan.cpp
+++ b/openmp/tools/archer/ompt-tsan.cpp
@@ -1224,7 +1224,7 @@ static void ompt_tsan_finalize(ompt_data_t *tool_data) {
if (archer_flags->print_max_rss) {
struct rusage end;
getrusage(RUSAGE_SELF, &end);
- printf("MAX RSS[KBytes] during execution: %ld\n", end.ru_maxrss);
+ printf("MAX RSS[KiB] during execution: %ld\n", end.ru_maxrss);
}
if (archer_flags)
|
|
@llvm/pr-subscribers-lld Author: Alexander Ziaee (concussious) ChangesIncrease specificity by using the correct unit sizes. KBytes is an abbreviation for kB, 1000 bytes, and the hardware industry as well as several operating systems have now switched to using 1000 byte kBs. If this change is acceptable, sometimes GitHub mangles merges to use the original email of the account. $dayjob asks contributions have my work email. Thanks! Full diff: https://github.com/llvm/llvm-project/pull/133148.diff 5 Files Affected:
diff --git a/lld/ELF/Relocations.cpp b/lld/ELF/Relocations.cpp
index 629702b45965b..0653f79890646 100644
--- a/lld/ELF/Relocations.cpp
+++ b/lld/ELF/Relocations.cpp
@@ -162,7 +162,7 @@ static RelType getMipsPairType(RelType type, bool isLocal) {
// symbol, the R_MIPS_GOT16 relocation creates a GOT entry to hold
// the high 16 bits of the symbol's value. A paired R_MIPS_LO16
// relocations handle low 16 bits of the address. That allows
- // to allocate only one GOT entry for every 64 KBytes of local data.
+ // to allocate only one GOT entry for every 64 KiB of local data.
return isLocal ? R_MIPS_LO16 : R_MIPS_NONE;
case R_MICROMIPS_GOT16:
return isLocal ? R_MICROMIPS_LO16 : R_MIPS_NONE;
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
index 67ba42f33d1dd..4a1117222f34c 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
@@ -1377,7 +1377,7 @@ GDBRemoteCommunicationServerCommon::GetModuleInfo(llvm::StringRef module_path,
std::vector<std::string> GDBRemoteCommunicationServerCommon::HandleFeatures(
const llvm::ArrayRef<llvm::StringRef> client_features) {
- // 128KBytes is a reasonable max packet size--debugger can always use less.
+ // 128 KiB is a reasonable max packet size--debugger can always use less.
constexpr uint32_t max_packet_size = 128 * 1024;
// Features common to platform server and llgs.
diff --git a/lldb/tools/debugserver/source/RNBRemote.cpp b/lldb/tools/debugserver/source/RNBRemote.cpp
index eb7c5ca32c02a..2ff4f29101f44 100644
--- a/lldb/tools/debugserver/source/RNBRemote.cpp
+++ b/lldb/tools/debugserver/source/RNBRemote.cpp
@@ -3477,7 +3477,7 @@ static bool GetProcessNameFrom_vAttach(const char *&p,
}
rnb_err_t RNBRemote::HandlePacket_qSupported(const char *p) {
- uint32_t max_packet_size = 128 * 1024; // 128KBytes is a reasonable max packet
+ uint32_t max_packet_size = 128 * 1024; // 128 KiB is a reasonable max packet
// size--debugger can always use less
std::stringstream reply;
reply << "qXfer:features:read+;PacketSize=" << std::hex << max_packet_size
diff --git a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
index 8bee87a22db16..fb91884d40132 100644
--- a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
+++ b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
@@ -122,7 +122,7 @@ std::optional<unsigned> X86TTIImpl::getCacheSize(
// - Broadwell
// - Skylake
// - Kabylake
- return 32 * 1024; // 32 KByte
+ return 32 * 1024; // 32 KiB
case TargetTransformInfo::CacheLevel::L2D:
// - Penryn
// - Nehalem
@@ -133,7 +133,7 @@ std::optional<unsigned> X86TTIImpl::getCacheSize(
// - Broadwell
// - Skylake
// - Kabylake
- return 256 * 1024; // 256 KByte
+ return 256 * 1024; // 256 KiB
}
llvm_unreachable("Unknown TargetTransformInfo::CacheLevel");
diff --git a/openmp/tools/archer/ompt-tsan.cpp b/openmp/tools/archer/ompt-tsan.cpp
index bb60fc6b603f4..c315999af4328 100644
--- a/openmp/tools/archer/ompt-tsan.cpp
+++ b/openmp/tools/archer/ompt-tsan.cpp
@@ -1224,7 +1224,7 @@ static void ompt_tsan_finalize(ompt_data_t *tool_data) {
if (archer_flags->print_max_rss) {
struct rusage end;
getrusage(RUSAGE_SELF, &end);
- printf("MAX RSS[KBytes] during execution: %ld\n", end.ru_maxrss);
+ printf("MAX RSS[KiB] during execution: %ld\n", end.ru_maxrss);
}
if (archer_flags)
|
|
@llvm/pr-subscribers-lld-elf Author: Alexander Ziaee (concussious) ChangesIncrease specificity by using the correct unit sizes. KBytes is an abbreviation for kB, 1000 bytes, and the hardware industry as well as several operating systems have now switched to using 1000 byte kBs. If this change is acceptable, sometimes GitHub mangles merges to use the original email of the account. $dayjob asks contributions have my work email. Thanks! Full diff: https://github.com/llvm/llvm-project/pull/133148.diff 5 Files Affected:
diff --git a/lld/ELF/Relocations.cpp b/lld/ELF/Relocations.cpp
index 629702b45965b..0653f79890646 100644
--- a/lld/ELF/Relocations.cpp
+++ b/lld/ELF/Relocations.cpp
@@ -162,7 +162,7 @@ static RelType getMipsPairType(RelType type, bool isLocal) {
// symbol, the R_MIPS_GOT16 relocation creates a GOT entry to hold
// the high 16 bits of the symbol's value. A paired R_MIPS_LO16
// relocations handle low 16 bits of the address. That allows
- // to allocate only one GOT entry for every 64 KBytes of local data.
+ // to allocate only one GOT entry for every 64 KiB of local data.
return isLocal ? R_MIPS_LO16 : R_MIPS_NONE;
case R_MICROMIPS_GOT16:
return isLocal ? R_MICROMIPS_LO16 : R_MIPS_NONE;
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
index 67ba42f33d1dd..4a1117222f34c 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
@@ -1377,7 +1377,7 @@ GDBRemoteCommunicationServerCommon::GetModuleInfo(llvm::StringRef module_path,
std::vector<std::string> GDBRemoteCommunicationServerCommon::HandleFeatures(
const llvm::ArrayRef<llvm::StringRef> client_features) {
- // 128KBytes is a reasonable max packet size--debugger can always use less.
+ // 128 KiB is a reasonable max packet size--debugger can always use less.
constexpr uint32_t max_packet_size = 128 * 1024;
// Features common to platform server and llgs.
diff --git a/lldb/tools/debugserver/source/RNBRemote.cpp b/lldb/tools/debugserver/source/RNBRemote.cpp
index eb7c5ca32c02a..2ff4f29101f44 100644
--- a/lldb/tools/debugserver/source/RNBRemote.cpp
+++ b/lldb/tools/debugserver/source/RNBRemote.cpp
@@ -3477,7 +3477,7 @@ static bool GetProcessNameFrom_vAttach(const char *&p,
}
rnb_err_t RNBRemote::HandlePacket_qSupported(const char *p) {
- uint32_t max_packet_size = 128 * 1024; // 128KBytes is a reasonable max packet
+ uint32_t max_packet_size = 128 * 1024; // 128 KiB is a reasonable max packet
// size--debugger can always use less
std::stringstream reply;
reply << "qXfer:features:read+;PacketSize=" << std::hex << max_packet_size
diff --git a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
index 8bee87a22db16..fb91884d40132 100644
--- a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
+++ b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
@@ -122,7 +122,7 @@ std::optional<unsigned> X86TTIImpl::getCacheSize(
// - Broadwell
// - Skylake
// - Kabylake
- return 32 * 1024; // 32 KByte
+ return 32 * 1024; // 32 KiB
case TargetTransformInfo::CacheLevel::L2D:
// - Penryn
// - Nehalem
@@ -133,7 +133,7 @@ std::optional<unsigned> X86TTIImpl::getCacheSize(
// - Broadwell
// - Skylake
// - Kabylake
- return 256 * 1024; // 256 KByte
+ return 256 * 1024; // 256 KiB
}
llvm_unreachable("Unknown TargetTransformInfo::CacheLevel");
diff --git a/openmp/tools/archer/ompt-tsan.cpp b/openmp/tools/archer/ompt-tsan.cpp
index bb60fc6b603f4..c315999af4328 100644
--- a/openmp/tools/archer/ompt-tsan.cpp
+++ b/openmp/tools/archer/ompt-tsan.cpp
@@ -1224,7 +1224,7 @@ static void ompt_tsan_finalize(ompt_data_t *tool_data) {
if (archer_flags->print_max_rss) {
struct rusage end;
getrusage(RUSAGE_SELF, &end);
- printf("MAX RSS[KBytes] during execution: %ld\n", end.ru_maxrss);
+ printf("MAX RSS[KiB] during execution: %ld\n", end.ru_maxrss);
}
if (archer_flags)
|
JDevlieghere
approved these changes
Mar 26, 2025
|
Thank you! This is my first time sending a patch here, how do I do that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase specificity by using the correct unit sizes. KBytes is an abbreviation for kB, 1000 bytes, and the hardware industry as well as several operating systems have now switched to using 1000 byte kBs.
If this change is acceptable, sometimes GitHub mangles merges to use the original email of the account. $dayjob asks contributions have my work email. Thanks!