Skip to content

[doc] Use ISO nomenclature for 1024 byte units #133148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lld/ELF/Relocations.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ static RelType getMipsPairType(RelType type, bool isLocal) {
// symbol, the R_MIPS_GOT16 relocation creates a GOT entry to hold
// the high 16 bits of the symbol's value. A paired R_MIPS_LO16
// relocations handle low 16 bits of the address. That allows
// to allocate only one GOT entry for every 64 KBytes of local data.
// to allocate only one GOT entry for every 64 KiB of local data.
return isLocal ? R_MIPS_LO16 : R_MIPS_NONE;
case R_MICROMIPS_GOT16:
return isLocal ? R_MICROMIPS_LO16 : R_MIPS_NONE;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1377,7 +1377,7 @@ GDBRemoteCommunicationServerCommon::GetModuleInfo(llvm::StringRef module_path,

std::vector<std::string> GDBRemoteCommunicationServerCommon::HandleFeatures(
const llvm::ArrayRef<llvm::StringRef> client_features) {
// 128KBytes is a reasonable max packet size--debugger can always use less.
// 128 KiB is a reasonable max packet size--debugger can always use less.
constexpr uint32_t max_packet_size = 128 * 1024;

// Features common to platform server and llgs.
Expand Down
2 changes: 1 addition & 1 deletion lldb/tools/debugserver/source/RNBRemote.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3477,7 +3477,7 @@ static bool GetProcessNameFrom_vAttach(const char *&p,
}

rnb_err_t RNBRemote::HandlePacket_qSupported(const char *p) {
uint32_t max_packet_size = 128 * 1024; // 128KBytes is a reasonable max packet
uint32_t max_packet_size = 128 * 1024; // 128 KiB is a reasonable max packet
// size--debugger can always use less
std::stringstream reply;
reply << "qXfer:features:read+;PacketSize=" << std::hex << max_packet_size
Expand Down
4 changes: 2 additions & 2 deletions llvm/lib/Target/X86/X86TargetTransformInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ std::optional<unsigned> X86TTIImpl::getCacheSize(
// - Broadwell
// - Skylake
// - Kabylake
return 32 * 1024; // 32 KByte
return 32 * 1024; // 32 KiB
case TargetTransformInfo::CacheLevel::L2D:
// - Penryn
// - Nehalem
Expand All @@ -133,7 +133,7 @@ std::optional<unsigned> X86TTIImpl::getCacheSize(
// - Broadwell
// - Skylake
// - Kabylake
return 256 * 1024; // 256 KByte
return 256 * 1024; // 256 KiB
}

llvm_unreachable("Unknown TargetTransformInfo::CacheLevel");
Expand Down
2 changes: 1 addition & 1 deletion openmp/tools/archer/ompt-tsan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,7 @@ static void ompt_tsan_finalize(ompt_data_t *tool_data) {
if (archer_flags->print_max_rss) {
struct rusage end;
getrusage(RUSAGE_SELF, &end);
printf("MAX RSS[KBytes] during execution: %ld\n", end.ru_maxrss);
printf("MAX RSS[KiB] during execution: %ld\n", end.ru_maxrss);
}

if (archer_flags)
Expand Down