Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InferReadWrite] Set builder insertion point to ensure dominance #6836

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

prithayan
Copy link
Contributor

This fixes a bug in InferReadWrite, the builder was not respecting dominance when updating the IR.
Ensure that the builder creates the constant at the start of the module, instead of at the memory op.
The bug was introduced in #6818

@prithayan prithayan merged commit 52a53ca into main Mar 16, 2024
4 checks passed
@prithayan prithayan deleted the dev/pbarua/inferRW_bug branch March 16, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant