[InferRW] Remove dependence of write-mode on enable for memory #6818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prithayan
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
prithayan
changed the title
|
@seldridge , @debs-sifive , I checked that this PR fixes the issue with the redundant |
prithayan
force-pushed
the
dev/pbarua/simplify_mem
branch
from
e5482ed
to
2205b3c
Compare
mikeurbach
reviewed
Mar 14, 2024
prithayan
force-pushed
the
dev/pbarua/simplify_mem
branch
from
2205b3c
to
2c7c0bb
Compare
|
Merged this now for the next release, post merge comments are welcome. |
prithayan
added a commit
that referenced
this pull request
Mar 16, 2024
This fixes a bug in InferReadWrite, the builder was not respecting dominance when updating the IR. Ensure that the builder creates the constant at the start of the module. The bug was introduced in #6818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read-write port of a memory has an input enable
ensignal and a write-modewmodesignal. Theensignal enables the port for either read/write mode. Thewmodeis enabled to set the memory in the write mode and disabled to read from the memory.This PR removes the dependency of
wmodeon theensignal of a read-write port of a memory.The
wmodesignal matters only if theenis enabled, hence traverse the expression tree for thewmodeand replaceenwith a constant1.