[FIRRTL][CheckCombLoops] don't crash on force+rwprobeop, workaround. #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unbreak this, at cost of missing loops through force, while the better fix is being worked out. cc llvm#6820.
prithayan
approved these changes
Mar 13, 2024
|
Thank you! |
seldridge
reviewed
Mar 13, 2024
| %0 = firrtl.asClock %c0_ui1 : (!firrtl.uint<1>) -> !firrtl.clock | ||
| firrtl.ref.force %clock, %c1_ui1, %clockProbe, %0 : !firrtl.clock, !firrtl.uint<1>, !firrtl.clock | ||
| } | ||
| } |
There was a problem hiding this comment.
Can the PR add an XFAIL test (would have to be another file) that is checking that a cycle involving a force is fixed?
There was a problem hiding this comment.
You got it, here: #6823 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbreak this, at cost of missing loops through force, while the better fix is being worked out.
cc #6820.