[firtool] Add option to treat EICG_wrapper as intrinsic #6499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
Add the `--fixup-eicg-wrapper` option to firtool and the LowerIntrinsics pass. Setting the option will treat `EICG_wrapper` modules like an intrinsic and replace them with the `firrtl.int.clock_gate` operation. In the long run, Chisel/FIRRTL designs will directly emit the clock gate intrinsic, and `EICG_wrapper` extmodules will be gone. However until we get there, this option provides an incremental path towards deprecating the `EICG_wrapper` pattern. It allows us to switch the CIRCT side of the flow over to the intrinsic without having to make changes to Chisel in lockstep. Once all relevant existing designs work with this switch enabled, Chisel projects can opt into emitting clock gates directly, and can gradually upgrade. At that point we can make firtool emit deprecation warnings for uses of `EICG_wrapper` extmodules, and at some point we can entirely drop special handling of these modules altogether. This switch is disabled by default and does not affect existing flows.
fabianschuiki
force-pushed
the
fschuiki/eicg-wrapper-deprecation-switch
branch
from
7f552ef
to
030b357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
--fixup-eicg-wrapperoption to firtool and the LowerIntrinsics pass. Setting the option will treatEICG_wrappermodules like an intrinsic and replace them with thefirrtl.int.clock_gateoperation.In the long run, Chisel/FIRRTL designs will directly emit the clock gate intrinsic, and
EICG_wrapperextmodules will be gone. However until we get there, this option provides an incremental path towards deprecating theEICG_wrapperpattern. It allows us to switch the CIRCT side of the flow over to the intrinsic without having to make changes to Chisel in lockstep. Once all relevant existing designs work with this switch enabled, Chisel projects can opt into emitting clock gates directly, and can gradually upgrade. At that point we can make firtool emit deprecation warnings for uses ofEICG_wrapperextmodules, and at some point we can entirely drop special handling of these modules altogether.This switch is disabled by default and does not affect existing flows.