Add Honeycomb open telemetry trace to LiquidVoting.list_votes/1 and votes/3 #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having to create a new vote to test telemetry.
No great breakthough, but let's keep this for now, as it successfully saves related spans from core api action and resolver action (list_votes/1 / votes/3). Also save related variable value (organization_id). We may not need this, but demonstrates we can do this kind of thing.
oliverbarnes
approved these changes
Mar 16, 2021
oliverbarnes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No great breakthough, but let's keep this for now, as it
successfully sends related spans from core api action and
resolver action (list_votes/1 / votes/3).
Also reports related variable value (organization_id). We may not need
this, but demonstrates we can do this kind of thing.