Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: resolve/remove TODO comments #709

Merged
merged 2 commits into from
May 25, 2023
Merged

refactor: resolve/remove TODO comments #709

merged 2 commits into from
May 25, 2023

Conversation

yitsushi
Copy link
Contributor

Additional changes:

  • If any of the main processes returns with an error, stop all other processes, for example if serveAPI fails, we can stop runControllers too.

References:

* #179 not relevant anymore
* Closes #233 becasue closer inspection, those errors can happen,
  but that does not mean the application has serious issues, the next loop can
  be successful, if it stuck in an error loop, it is visible in logs.
* #206, we have an issue to track that, we don't need an extra comment about it.
* Closes #235, we can return with an error, and the caller can handle it.

Additional changes:
* If any of the main processes returns with an error, stop all other processes,
  for example if `serveAPI` fails, we can stop `runControllers` too.

References:
* #179
* #233
* #206
* #235

Signed-off-by: Balazs Nadasdi <balazs@weave.works>
@yitsushi yitsushi added the kind/cleanup Removing things previously overlooked label May 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (18c06de) 58.26% compared to head (a7d6e55) 58.11%.

❗ Current head a7d6e55 differs from pull request most recent head 3ad2c8e. Consider uploading reports for the commit 3ad2c8e to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   58.26%   58.11%   -0.15%     
==========================================
  Files          56       56              
  Lines        2705     2705              
==========================================
- Hits         1576     1572       -4     
- Misses        984      986       +2     
- Partials      145      147       +2     
Impacted Files Coverage Δ
core/models/network.go 100.00% <ø> (ø)
infrastructure/controllers/microvm_controller.go 68.22% <ø> (ø)
infrastructure/network/network_service.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Callisto13 Callisto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t really mind having lines pointing at other issues because it gives me a place to search when picking up 🤷‍♀️

Otherwise LGTM

@yitsushi yitsushi enabled auto-merge (squash) May 25, 2023 05:25
@yitsushi yitsushi merged commit eb239ae into main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Removing things previously overlooked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Fatalf call from serveAPI Revisit logger.Errorf calls in runEventListener
3 participants