Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit logger.Errorf calls in runEventListener #233

Closed
yitsushi opened this issue Nov 9, 2021 · 3 comments · Fixed by #709
Closed

Revisit logger.Errorf calls in runEventListener #233

yitsushi opened this issue Nov 9, 2021 · 3 comments · Fixed by #709
Labels
good first issue Good for newcomers help wanted Requires help from contributors to get done kind/refactor Only refactoring changes lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@yitsushi
Copy link
Contributor

yitsushi commented Nov 9, 2021 •
edited
Loading

Describe the solution you'd like:
Right now the code has a TODO mark, so just resolve it. Keeping the Errorf calls is a valid option.

Why do you want this feature:
No TODO comments should live in the code without filed issues to track them.

Anything else you would like to add:
https://github.com/weaveworks/flintlock/blob/main/infrastructure/controllers/microvm_controller.go#L91,L103
@yitsushi yitsushi added the kind/refactor Only refactoring changes label Nov 9, 2021
@richardcase richardcase added good first issue Good for newcomers help wanted Requires help from contributors to get done priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 10, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2022
@Callisto13 Callisto13 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
@yitsushi
Copy link
Contributor Author

Still valid.

yitsushi added a commit that referenced this issue May 19, 2023
@yitsushi
refactor: resolve/remove TODO comments
caffd11 
* #179 not relevant anymore
* Closes #233 becasue closer inspection, those errors can happen,
  but that does not mean the application has serious issues, the next loop can
  be successful, if it stuck in an error loop, it is visible in logs.
* #206, we have an issue to track that, we don't need an extra comment about it.
* Closes #235, we can return with an error, and the caller can handle it.

Additional changes:
* If any of the main processes returns with an error, stop all other processes,
  for example if `serveAPI` fails, we can stop `runControllers` too.

References:
* #179
* #233
* #206
* #235

Signed-off-by: Balazs Nadasdi <balazs@weave.works>
@yitsushi yitsushi mentioned this issue May 19, 2023
Merged
yitsushi added a commit that referenced this issue May 25, 2023
@yitsushi
refactor: resolve/remove TODO comments (#709)
eb239ae 
* #179 not relevant anymore
* Closes #233 becasue closer inspection, those errors can happen,
  but that does not mean the application has serious issues, the next loop can
  be successful, if it stuck in an error loop, it is visible in logs.
* #206, we have an issue to track that, we don't need an extra comment about it.
* Closes #235, we can return with an error, and the caller can handle it.

Additional changes:
* If any of the main processes returns with an error, stop all other processes,
  for example if `serveAPI` fails, we can stop `runControllers` too.

References:
* #179
* #233
* #206
* #235

Signed-off-by: Balazs Nadasdi <balazs@weave.works>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Requires help from contributors to get done kind/refactor Only refactoring changes lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
No open projects
Liquid Metal Roadmap - Public
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: resolve/remove TODO comments liquidmetal-dev/flintlock
3 participants
@yitsushi @richardcase @Callisto13