Merge caffd11 into 87684fd

core/models/network.go

@@ -14,7 +14,6 @@ type NetworkInterface struct {
 	//
 	// NOTE: This field is not exposed via the gRPC API, it is automatically
 	// populated when converting from the API model to this internal model.
-	// TODO: we may hide this within the firecracker plugin. #179
 	AllowMetadataRequests bool `json:"allow_mmds,omitempty"`
 	// GuestMAC allows the specifying of a specifi MAC address to use for the interface. If
 	// not supplied a autogenerated MAC address will be used.

infrastructure/controllers/microvm_controller.go

@@ -101,16 +101,13 @@ func (r *MicroVMController) runEventListener(ctx context.Context, resyncPeriod t
 			return
 		case evt := <-evtCh:
 			if err := r.handleEvent(evt, logger); err != nil {
-				// TODO: should we exit here? #233
 				logger.Errorf("handling events: %s", err)
 			}
 		case <-ticker.C:
 			if err := r.resyncSpecs(ctx, logger); err != nil {
-				// TODO: should we exit here? #233
 				logger.Errorf("resyncing specs: %s", err)
 			}
 		case evtErr := <-errCh:
-			// TODO: should we exit here? #233
 			logger.Errorf("error from event service: %s", evtErr)
 		}
 	}

infrastructure/godisk/disk_service_test.go

@@ -50,8 +50,6 @@ func TestDiskCreation(t *testing.T) {
 	info, err := fs.Stat(imagePath)
 	g.Expect(err).NotTo(g.HaveOccurred())
 	g.Expect(info.Size()).To(g.Equal(expectedSize))
-
-	//TODO: in the future we could consider inspecting the created image.
 }
 
 func TestDiskCreationExistsNoOverwrite(t *testing.T) {

infrastructure/network/network_service.go

@@ -74,7 +74,6 @@ func (n *networkService) IfaceCreate(ctx context.Context, input ports.IfaceCreat
 		link = &netlink.Tuntap{
 			LinkAttrs: netlink.LinkAttrs{
 				Name: input.DeviceName,
-				// TODO: add Namespace #206
 			},
 			Mode: netlink.TUNTAP_MODE_TAP,
 		}
@@ -85,7 +84,7 @@ func (n *networkService) IfaceCreate(ctx context.Context, input ports.IfaceCreat
 					Name:        input.DeviceName,
 					MTU:         parentLink.Attrs().MTU,
 					ParentIndex: parentLink.Attrs().Index,
-					Namespace:   parentLink.Attrs().Namespace, // TODO: add namespace specific to vm #206
+					Namespace:   parentLink.Attrs().Namespace,
 					TxQLen:      parentLink.Attrs().TxQLen,
 				},
 				Mode: netlink.MACVLAN_MODE_BRIDGE,

internal/command/run/run.go

@@ -109,6 +109,8 @@ func runServer(ctx context.Context, cfg *config.Config) error {
 
 			if err := runPProf(ctx, cfg); err != nil {
 				logger.Errorf("failed serving api: %v", err)
+				// Cancel all processes if at least one fails.
+				cancel()
 			}
 		}()
 	}
@@ -121,6 +123,8 @@ func runServer(ctx context.Context, cfg *config.Config) error {
 
 			if err := serveAPI(ctx, cfg); err != nil {
 				logger.Errorf("failed serving api: %v", err)
+				// Cancel all processes if at least one fails.
+				cancel()
 			}
 		}()
 	}
@@ -132,6 +136,8 @@ func runServer(ctx context.Context, cfg *config.Config) error {
 			defer wg.Done()
 			if err := serveHTTP(ctx, cfg); err != nil {
 				logger.Errorf("failed serving http api: %v", err)
+				// Cancel all processes if at least one fails.
+				cancel()
 			}
 		}()
 	}
@@ -144,6 +150,8 @@ func runServer(ctx context.Context, cfg *config.Config) error {
 
 			if err := runControllers(ctx, cfg); err != nil {
 				logger.Errorf("failed running controllers: %v", err)
+				// Cancel all processes if at least one fails.
+				cancel()
 			}
 		}()
 	}
@@ -202,7 +210,7 @@ func serveAPI(ctx context.Context, cfg *config.Config) error {
 	reflection.Register(grpcServer)
 
 	if err := grpcServer.Serve(listener); err != nil {
-		logger.Fatalf("serving grpc api: %v", err) // TODO: remove this fatal #235
+		return fmt.Errorf("failed to start grpc server: %w", err)
 	}
 
 	return nil