Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization - Support for Spanish Localization #239 #245

Closed
wants to merge 5 commits into from

Conversation

tadpole2077
Copy link
Contributor

Localization - Support for Spanish Localization #239

@tadpole2077
Copy link
Contributor Author

dont use this one, i see the pull includes later commits (8c14dff) to my forked master. I've added a tag (releases/tag/V4.0.0.0pre4_ES_Locale) to pull just the related files.

@tadpole2077
Copy link
Contributor Author

tadpole2077 commented Mar 11, 2021

Can't seem to drop this Pull request and replace with a new one, maybe only one pull request is allowed per user.. So don't merge the files in "Load Testing - Identification of DNS timeout issue under load or in...". Or drop this pull request and i'll generate a new one, which ever is easier for you.

@lieser
Copy link
Owner

lieser commented Mar 14, 2021

Thanks a lot for the translation.
I manually added your changes in ee33749.

Note that I reordered your entry in content\options.html. Otherwise it should be the same as in your V4.0.0.0pre4_ES_Locale tag (8bea02d).

Can't seem to drop this Pull request and replace with a new one, maybe only one pull request is allowed per user

I would expect that you can open more than one pull request. But only once for each branch.

In the future, if you want to add some temporary test code, I recommend looking into working with branches in git. see e.g. https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell for a tutorial. There are probably also some less technical ones out there.

@lieser lieser closed this Mar 14, 2021
@lieser lieser self-assigned this Mar 14, 2021
@lieser lieser added this to the 4.0.0 milestone Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants