Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization - Support for Spanish Localization #239

Closed
tadpole2077 opened this issue Feb 12, 2021 · 9 comments
Closed

Localization - Support for Spanish Localization #239

tadpole2077 opened this issue Feb 12, 2021 · 9 comments
Milestone

Comments

@tadpole2077
Copy link
Contributor

Add support for Spanish Localization, and subfolder for ES-es under _locales.
Using European Castilian Spanish

@tadpole2077
Copy link
Contributor Author

I'm working on this now, should be done within the next week.

@lieser
Copy link
Owner

lieser commented Feb 12, 2021

Thanks for letting me know, and nice to see that the add-on will get another translation. If there is something unclear with the strings, don't hesitate to ask.

Note that on https://www.babelzilla.org someone named strel started a Spanish translation a while back, but never finished it.

Attached is what he translated. Note that it is still in the old format
dkim.properties.txt.

Please let me know if you integrate his work instead of just starting from scratch, so that he will get attributed in that case.

@tadpole2077
Copy link
Contributor Author

Ok thanks for the additional legacy work file reference, i'll cross-reference/review it when defining the new ES translations. but likely will not use it directly (of course some strings will be identical). looks like Strel got about 40% though the message list.

@tadpole2077
Copy link
Contributor Author

2021_02_19 50% complete.. ETA 1 week more

@tadpole2077
Copy link
Contributor Author

Task completed, ready to commit to master. Tested on local env - all good.
o ./_locales/es_ES/* {4 files}
o ./chrome.manifest
o ./install.rdf
o ./content/options.html

How should I do the commit as commit access permission is locked?

@lieser
Copy link
Owner

lieser commented Mar 10, 2021

Nice to hear you are finished, and sorry for the late reply.

GitHub works mainly with pull request for collaboration.

You need to:

  1. create a fork https://docs.github.com/en/github/getting-started-with-github/fork-a-repo
  2. push your changes to your fork
  3. create a pull request https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

Note that ./chrome.manifest and ./install.rdf are outdated files that you didn't have to change (./install.rdf has already ben deleted). As you seem to be new to git/GitHub, don't worry about cleaning that up.
If you keep the Allow edits from maintainers checkbox enabled then you create the pull request, I should be able to do that myself.

tadpole2077 added a commit to tadpole2077/dkim_verifier that referenced this issue Mar 11, 2021
tadpole2077 added a commit to tadpole2077/dkim_verifier that referenced this issue Mar 11, 2021
tadpole2077 added a commit to tadpole2077/dkim_verifier that referenced this issue Mar 11, 2021
@tadpole2077
Copy link
Contributor Author

Grand, i had already forked the project last year, and was working off of that. I just committed and added a pull request above.

Actually had to revert out all unrelated stuff that i'm playing with regarding load testing of DNSServer queries and intermittent timeouts to narrow the pull to related files for ES localization.

What's next on the development pipeline, happy to help out, just id issues that need review.

@lieser
Copy link
Owner

lieser commented Mar 14, 2021

Will leave this open as a reminder to upload the Spanish descriptions to ATN.

What's next on the development pipeline

I'm in the process of moving the last missing pieces from the 3.x Version to the 4.x Version. Afterwards the short term plan is in https://github.com/lieser/dkim_verifier/milestone/16.
I currently don't have a clear long term plan.

happy to help out, just id issues that need review.

It is a little unclear to me, are you offering to review changes I do, or are you interested in doing some development work yourself?
If it is doing development yourself, you could do any of the open feature request that interests you. I could also look over them and try if I see an easy starting issue.

If more people start to contribute, I also think this repo should get some CI, instead of me running the tools (unit tests, eslint, type checking) just locally.
This could also be something you could look into.

@lieser lieser added this to the 4.0.0 milestone Mar 28, 2021
@lieser
Copy link
Owner

lieser commented Apr 11, 2021

Translation is added to ATN: https://addons.thunderbird.net/es/thunderbird/addon/dkim-verifier/

@lieser lieser closed this as completed Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants