[hotfixes] Configure task behavior to acknowledge after execution to trigger requeuing when interrupted#3304
Merged
rtibbles merged 2 commits intolearningequality:hotfixesfrom Nov 30, 2021
Conversation
…ueuing when interrupted
|
SonarCloud Quality Gate failed.
|
rtibbles
approved these changes
Nov 30, 2021
Member
rtibbles
left a comment
There was a problem hiding this comment.
Works as described in local testing.
This was referenced Jun 27, 2022
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










Summary
Testing on hotfixes separately
Description of the change(s) you made
Manual verification steps performed
Logging snapshots
When a worker is forcibly interrupted, it should restore (unacknowledged) tasks to the queue:
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
time.sleep(10000)to a task such as the publish taskCtrl+CRestoring 1 unacknowledged message(s); other incomplete scheduled tasks should be included such as tasks with an ETAAre there any risky areas that deserve extra testing?
References
https://docs.celeryproject.org/en/v4.4.7/userguide/configuration.html#std:setting-task_acks_late
https://docs.celeryproject.org/en/v4.4.7/faq.html#faq-acks-late-vs-retry
Querying celery queue directly:
redis-cli LRANGE celery 0 -1Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)