Skip to content

Comments

Revert Celery Late Acknowledgement#3984

Merged
bjester merged 3 commits intolearningequality:unstablefrom
vkWeb:revert-late-ack
Apr 12, 2023
Merged

Revert Celery Late Acknowledgement#3984
bjester merged 3 commits intolearningequality:unstablefrom
vkWeb:revert-late-ack

Conversation

@vkWeb
Copy link
Member

@vkWeb vkWeb commented Mar 14, 2023

Summary

This PR reverts celery's late acknowledgement config that was enabled on #3304.

Manual verification steps performed

  1. Added time.sleep(10000) to publish function to make it wait for long time.
  2. Start publishing a channel.
  3. Quickly press ctrl+c twice on celery's terminal. The second ctrl+c tap should be quick otherwise python handles the interrupt.
  4. Make sure the channel is marked still as publishing even though the worker has crashed.
  5. Run the management command python contentcuration/manage.py reconcile_publishing_status.
  6. You'll see the publishing status is resetted to False for that channel.

Reviewer guidance

Performing manual verfication steps.

References

Closes #3968.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb vkWeb requested a review from bjester March 14, 2023 15:06
@vkWeb vkWeb marked this pull request as draft March 14, 2023 15:16
@vkWeb
Copy link
Member Author

vkWeb commented Mar 14, 2023

Converted to draft. Because there's feedback that required re-design of the command.

@vkWeb vkWeb marked this pull request as ready for review March 27, 2023 09:12
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing concurs-- this works great! 🎉

@bjester bjester merged commit b9729c5 into learningequality:unstable Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Channel is already publishing-- revert late acknowledgment

2 participants