Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR for Sprint ending 2021-04-12 #3087

Merged
merged 24 commits into from
Apr 15, 2021
Merged

Release PR for Sprint ending 2021-04-12 #3087

merged 24 commits into from
Apr 15, 2021

Conversation

bjester
Copy link
Member

@bjester bjester commented Apr 12, 2021

Summary

  • Resolves issue with filtering Content Library channels by "Starred" (Bookmark)
  • Resolves issue with searching for channels in Studio admin UI
  • Re-enables editing of channels by admin users
  • Other miscellaneous bug fixes
PR Category QA Focus
#3070 Bug fix Starring channels and filtering by Starred
#3053 Bug fix Channel resource navigation
#3055 Bug fix Verify Channel list page works with Opera browser version < 56 via BrowserStack
#3051 Bug fix Edit channel as admin without normal edit permissions
#3054 Bug fix Search for channel as admin within admin interface
#3090 Bug fix Publish a small channel
#3052 Security update N/A

QA Scenarios

Starring channels and filtering by Starred (also known as bookmarking)

  1. Log in as a non-admin user
  2. Click on the "Content Library" tab
  3. Star a few channels by clicking on the star icon on its card
  4. After 10 seconds, click on the "Starred" filter checkbox on the left-hand side under "Formats" to filter all bookmarked channels
  5. Verify the channels you previously starred are shown
  6. Unstar a channel by clicking on the star icon on the card
  7. Uncheck the "Starred" filter and wait 10 seconds
  8. Click on the "Starred" filter again
  9. Verify the unstarred channel is no longer listed

Channel resource navigation

  1. Open an existing channel with resources
  2. Click on a topic in the main topic view and verify it opens the topic
  3. Click on a topic's right-arrow chevron in the main topic view and verify it opens the topic
  4. Click on a resource in the main topic view and verify it opens its details panel

Edit channel as admin without normal edit permissions

  1. Log onto non-production studio as an admin user
  2. Open the Administration interface from the account navigation on the Channel List page
  3. Open another user's channel that your user doesn't have edit permissions for
  4. Verify the channel is not shown as "View-Only" and that you can make edits to the channel

Search for channel as admin within admin interface

  1. Log onto studio as an admin user
  2. Open the Administration interface from the account navigation on the Channel List page
  3. Search for a channel
  4. Verify channels are filtered for your search query

Publish a small channel

  1. Open a small channel
  2. Click Publish
  3. You should observe a loading spinner until the resource size task completes
  4. Verify you see the channel size once it does complete

rtibbles and others added 13 commits March 29, 2021 14:31
…s-2.7.4

Bump pygments from 2.5.2 to 2.7.4
Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>
Check event has a target before checking the target tagName.
…n/y18n-3.2.2

Bump y18n from 3.2.1 to 3.2.2
Merge Sprint release 2021-03-29 back into hotfixes
Merge Sprint release 2021-03-29 back into hotfixes
…03-29

Merge pull request #3062 from learningequality/sprint-release-2021-03-29
@bjester bjester changed the title Release for Sprint 2021-04-12 Release PR for Sprint ending 2021-04-12 Apr 12, 2021
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #3087 (7ddca73) into master (c04ed76) will increase coverage by 0.03%.
The diff coverage is 92.47%.

❗ Current head 7ddca73 differs from pull request most recent head 516d79d. Consider uploading reports for the commit 516d79d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3087      +/-   ##
==========================================
+ Coverage   85.93%   85.96%   +0.03%     
==========================================
  Files         304      305       +1     
  Lines       16403    16478      +75     
==========================================
+ Hits        14096    14166      +70     
- Misses       2307     2312       +5     
Impacted Files Coverage Δ
contentcuration/contentcuration/tasks.py 60.34% <ø> (+2.71%) ⬆️
contentcuration/contentcuration/utils/user.py 72.72% <70.00%> (-27.28%) ⬇️
...ontentcuration/contentcuration/viewsets/channel.py 80.53% <85.18%> (+0.78%) ⬆️
contentcuration/contentcuration/models.py 84.58% <100.00%> (ø)
...curation/contentcuration/tests/utils/test_nodes.py 95.19% <100.00%> (-4.81%) ⬇️
...ion/contentcuration/tests/viewsets/test_channel.py 94.17% <100.00%> (+1.26%) ⬆️
contentcuration/contentcuration/utils/nodes.py 83.81% <100.00%> (-0.63%) ⬇️
...ontentcuration/contentcuration/utils/pagination.py 81.81% <0.00%> (-2.28%) ⬇️
...tentcuration/migrations/0123_auto_20210407_0057.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04ed76...516d79d. Read the comment docs.

Fix star/bookmarking feature in Content Library
@bjester bjester marked this pull request as ready for review April 12, 2021 19:54
@bjester bjester added this to the Sprint 2021-04-12 milestone Apr 12, 2021
@bjester bjester requested review from radinamatic and rtibbles April 12, 2021 21:48
@radinamatic
Copy link
Member

PR Category Comment Status
#3070 Bug fix Starring channels and filtering by Starred Fixed ✔️
#3053 Bug fix Channel resource navigation Fixed ✔️
#3055 Bug fix Verify Channel list page works with Opera browser version < 56 via BrowserStack Fixed ✔️
#3051 Bug fix Edit channel as admin without normal edit permissions Fixed ✔️
#3054 Bug fix Search for channel as admin within admin interface Fixed ✔️
#3090 Bug fix Publish a small channel Fixed ✔️

We are good to go!!! 💯 👏🏽

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away! 💥

@rtibbles rtibbles merged commit d2892c8 into master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants