You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bjester, after testing this change I can confirm that the the channel size is displayed now in the modal window. However for some reason it takes a lot of time before that happens even for a very small channel and I have an excellent internet connection.
For example I created a channel with just a single small imported resource (token: nozak-rugol) and it still took about 2 minutes of waiting before the size of the channel was calculated and displayed.
Confirming the findings by @pcenov: it takes almost 2 minutes to get the channel size calculated and for spinner to disappear on both channel with 82 resources and the one with just 2 resources 🤔
@pcenov@radinamatic Thank you for your testing insights! That is indeed a longer wait than expected. This change removed the synchronous calculation which forces the calculation to be queued for our async task workers. If there are a lot of tasks in the queue, that will slow down the processing, which is difficult to get a realistic read in a local development environment. Therefore it does seem that we should reinstate synchronous processing, but we should decrease the threshold from 5000 resources. I'll plan a follow up for next release!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronous calculations of resource size are taking too long.
Description of the change(s) you made
Changes the constant used to determine whether it should try calculation synchronously or not such that it shouldn't try to do so
Manual verification steps performed
References
Addresses: #3084
Follow up: #3089
Gherkin: integration_testing/features/publish-channel.feature
Contributor's Checklist
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)