Skip to content

Don't pass unsanitized inputs into regex.#3054

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:admin_channels
Apr 12, 2021
Merged

Don't pass unsanitized inputs into regex.#3054
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:admin_channels

Conversation

@rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Removes use of regex in admin channels search
  • Replaces with explicitly ORed Q filters doing an icontains match against each option

Manual verification steps performed

  1. Go to admin page
  2. Search channels
  3. See results!

References

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #3054 (5c54628) into hotfixes (c04ed76) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           hotfixes    #3054      +/-   ##
============================================
- Coverage     85.93%   85.92%   -0.02%     
============================================
  Files           304      304              
  Lines         16403    16408       +5     
============================================
+ Hits          14096    14098       +2     
- Misses         2307     2310       +3     
Impacted Files Coverage Δ
...ontentcuration/contentcuration/viewsets/channel.py 79.12% <33.33%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04ed76...5c54628. Read the comment docs.

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can search for channels

@bjester bjester merged commit 46e83fd into learningequality:hotfixes Apr 12, 2021
@bjester bjester added this to the Sprint 2021-04-12 milestone Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataError: invalid regular expression: parentheses () not balanced

2 participants