Skip to content

Remote Content Browsing: Clean the library page when displaying other available libraries.#10420

Merged
marcellamaki merged 2 commits intolearningequality:developfrom
AllanOXDi:remote_content_browsing_functionality
Apr 7, 2023
Merged

Remote Content Browsing: Clean the library page when displaying other available libraries.#10420
marcellamaki merged 2 commits intolearningequality:developfrom
AllanOXDi:remote_content_browsing_functionality

Conversation

@AllanOXDi
Copy link
Member

Summary

This PR clean the library page when displaying other available libraries.

References

Reviewer guidance

Please see the figma design

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: large labels Apr 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes make sense to me from a read through, and nothing is jumping out at me as blocking. Would be good to merge this ASAP so we can continue to build on top of it.

required: false,
default: 0,
},
allDevices: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this prop name could be changed just to device? As it seems from looking at the code this is just the information for a single device. allDevices suggests more than one to me!

},
},
methods: {
getDeviceIcon(device) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this component only handles one device at a time, this could be a computed prop instead, referencing this.device

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AllanOXDi - thanks for your work on this! I'm of similar mind to Richard. This is some good foundational work, and I think we should merge it and anything that remains, we can distribute among the team as follow up :)

I'll go ahead and merge, and then on Monday I'll prep any needed follow up issues on the Remote Browsing feature overall to be ready for the team to help with this coming iteration 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants