Remote Content Browsing: Clean the library page when displaying other available libraries.#10420
Remote Content Browsing: Clean the library page when displaying other available libraries.#10420marcellamaki merged 2 commits intolearningequality:developfrom AllanOXDi:remote_content_browsing_functionality
Conversation
Build Artifacts
|
rtibbles
left a comment
There was a problem hiding this comment.
The code changes make sense to me from a read through, and nothing is jumping out at me as blocking. Would be good to merge this ASAP so we can continue to build on top of it.
| required: false, | ||
| default: 0, | ||
| }, | ||
| allDevices: { |
There was a problem hiding this comment.
I wonder if this prop name could be changed just to device? As it seems from looking at the code this is just the information for a single device. allDevices suggests more than one to me!
| }, | ||
| }, | ||
| methods: { | ||
| getDeviceIcon(device) { |
There was a problem hiding this comment.
As this component only handles one device at a time, this could be a computed prop instead, referencing this.device
marcellamaki
left a comment
There was a problem hiding this comment.
Hi @AllanOXDi - thanks for your work on this! I'm of similar mind to Richard. This is some good foundational work, and I think we should merge it and anything that remains, we can distribute among the team as follow up :)
I'll go ahead and merge, and then on Monday I'll prep any needed follow up issues on the Remote Browsing feature overall to be ready for the team to help with this coming iteration 🎉
Summary
This PR clean the library page when displaying other available libraries.
References
Reviewer guidance
Please see the figma design
Testing checklist
PR process
Reviewer checklist
yarnandpip)