Skip to content

Remote content browsing followup#10457

Merged
marcellamaki merged 2 commits intolearningequality:developfrom
AllanOXDi:remote_content_browsing_followup
Apr 12, 2023
Merged

Remote content browsing followup#10457
marcellamaki merged 2 commits intolearningequality:developfrom
AllanOXDi:remote_content_browsing_followup

Conversation

@AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Apr 12, 2023

Summary

This PR is following up a review comments on #10420

References

#10420

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added the APP: Learn Re: Learn App (content, quizzes, lessons, etc.) label Apr 12, 2023
@AllanOXDi AllanOXDi requested a review from rtibbles April 12, 2023 13:10
@github-actions
Copy link
Contributor

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have addressed all of @rtibbles 's comments!

@marcellamaki marcellamaki merged commit 66dbcac into learningequality:develop Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants