Remote content browsing followup#10457
Merged
marcellamaki merged 2 commits intolearningequality:developfrom Apr 12, 2023
AllanOXDi:remote_content_browsing_followup
Merged
Remote content browsing followup#10457marcellamaki merged 2 commits intolearningequality:developfrom AllanOXDi:remote_content_browsing_followup
marcellamaki merged 2 commits intolearningequality:developfrom
AllanOXDi:remote_content_browsing_followup
Conversation
Contributor
Build Artifacts
|
marcellamaki
approved these changes
Apr 12, 2023
Member
marcellamaki
left a comment
There was a problem hiding this comment.
Seems to have addressed all of @rtibbles 's comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is following up a review comments on #10420
…
References
#10420
Testing checklist
PR process
Reviewer checklist
yarnandpip)