adds logic to LibraryPage to optionally display a particular device's… by akolson · Pull Request #10227 · learningequality/kolibri

akolson · 2023-03-10T18:47:00Z

Summary

This PR implements the ability to explore a device's library. Please see #9854 for spec details and figma designs

References

Closes #9854

Reviewer guidance

To review;

Login into Kolibri
Go to /learn/#/explore_libraries via the browser address bar
On load, click on the Explore button of any of the libraries displayed

Testing checklist

Contributor has fully tested the PR manually
If there are any front-end changes, before/after screenshots are included
Critical user journeys are covered by Gherkin stories
Critical and brittle code paths are covered by unit tests

PR process

PR has the correct target branch and milestone
PR has 'needs review' or 'work-in-progress' label
If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
If this is an important user-facing change, PR or related issue has a 'changelog' label
If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

Automated test coverage is satisfactory
PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

github-actions · 2023-03-10T19:06:45Z

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0a8.dev0_git.203.gee5d6e40.pex
Windows Installer (EXE)	kolibri-0.16.0a8.dev0+git.203.gee5d6e40-unsigned.exe
Debian Package	kolibri_0.16.0a8.dev0+git.203.gee5d6e40-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0a8.dev0+git.203.gee5d6e40-0.3.0.dmg
Source Tarball	kolibri-0.16.0a8.dev0+git.203.gee5d6e40.tar.gz
WHL file	kolibri-0.16.0a8.dev0+git.203.gee5d6e40-py2.py3-none-any.whl

rtibbles

This all makes sense to me - and for the Studio piece until we get the backend APIs on Studio unstable at least, this is the best we can do to test out the UI.

Interested if there's any intersection here with @bjester's work on the device listing that might be useful!

rtibbles · 2023-03-10T19:46:50Z

kolibri/plugins/learn/assets/src/modules/recommended/handlers.js

+   * during development
+   */
+  if (deviceId === KolibriStudioId) {
+    RemoteChannelResource.getKolibriStudioStatus().then(({ data }) => {


Flagging for any other reviewers that until we have a Studio server with the new public content APIs in them, we have to do it this way.

rtibbles · 2023-03-10T19:47:54Z

kolibri/plugins/learn/kolibri_plugin.py

            "gradeLevels": label_metadata["grade_levels"],
            "accessibilityLabels": label_metadata["accessibility_labels"],
            "learnerNeeds": label_metadata["learner_needs"],
+            "baseurl": conf.OPTIONS["Urls"]["CENTRAL_CONTENT_BASE_URL"],


Could we call this studio_baseurl to make it more explicit?

rtibbles · 2023-03-10T19:48:18Z

kolibri/plugins/learn/assets/src/views/LibraryPage/index.vue

      },
    },
    $trs: {
+      libraryOf: {


@marcellamaki @radinamatic flagging the string movement here and in the next file.

jredrejo

I have some doubts in how this should work, not sure if it is because of my lack of understanding of the remote browsing or an actual issue.

jredrejo · 2023-03-13T18:27:47Z

kolibri/plugins/learn/assets/src/modules/recommended/handlers.js

+  } else {
+    if (deviceId) {
+      return setCurrentDevice(deviceId).then(device => {
+        const baseurl = deviceId === KolibriStudioId ? plugin_data.studio_baseurl : device.base_url;


maybe this is a naive question, but wouldn't it be possible to reuse the code from the device channel in the showAvailableChannelsPage function instead of rewritting something so similar?

Ultimately, we should remove most of this special casing, once we have a version of Studio that we can test against that supports the v2 public content APIs, then all we need to do is pass in the Studio baseurl, and channels and resources should all be fetched properly from Studio.

jredrejo · 2023-03-13T18:39:35Z

kolibri/plugins/learn/assets/src/modules/recommended/handlers.js

+      if (data.status === 'online') {
+        RemoteChannelResource.fetchCollection().then(channels => {
+          //This is a hack to return kolibri channels.
+          store.commit('SET_ROOT_NODES', channels);


maybe I don't understand how this should work, but the result are different of what I expected:

The explored device has only one channel, as seen in the network request, however rootNodes is set to 10 channels that I don't know where they come from, but not from the explored device.

@jredrejo it looks like the current implementation within the LibraryPage returns the previously loaded library channels as the newly selected library loads. This is an issue that I think should be resolved once loading states are streamlined across the remote content browsing feature. @rtibbles any thoughts on this?

yep, it's showing both the channels existing in the local device plus the one on the remote device.

Though the behavior is for previous results to be cleared once the loading is complete for remote devices. Not very sure the behavior with locally hosted devices

Yes, the lack of the loading state is key here - especially as local channels are bootstrapped into the page so there's no loading at all.

… library

rtibbles

This is good to merge, but more to do on top of this!

akolson added this to the Kolibri 0.16 Release: Remote Content Browsing milestone Mar 10, 2023

github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: backend Python, databases, networking, filesystem... SIZE: medium labels Mar 10, 2023

rtibbles reviewed Mar 10, 2023

View reviewed changes

akolson requested review from AllanOXDi, jredrejo and marcellamaki March 10, 2023 20:03

akolson assigned marcellamaki Mar 10, 2023

akolson requested a review from rtibbles March 10, 2023 20:13

akolson marked this pull request as ready for review March 10, 2023 20:13

akolson requested a review from nucleogenesis March 10, 2023 20:14

jredrejo reviewed Mar 13, 2023

View reviewed changes

akolson added 5 commits March 14, 2023 22:04

adds logic to LibraryPage to optionally display a particular device's…

a35c401

… library

cleans up code

441934c

cleans up code

667d2f7

Adds review feedback

633fbda

Adds review feedback

dcb88b4

akolson force-pushed the explore-library branch from 6cf054e to dcb88b4 Compare March 14, 2023 19:05

Merges latest develop

ace1329

rtibbles approved these changes Mar 14, 2023

View reviewed changes

akolson merged commit b65590c into learningequality:develop Mar 14, 2023

akolson mentioned this pull request Mar 14, 2023

adds ability to explore channel on 'Explore Libraries' page #10248

Merged

9 tasks

rtibbles mentioned this pull request Mar 20, 2023

Finalize Studio remote browsing integration #10280

Closed

akolson mentioned this pull request Mar 31, 2023

Remote Content Browsing: Clean the library page when displaying other available libraries #10354

Closed

9 tasks

akolson deleted the explore-library branch January 9, 2026 11:30

Conversation

akolson commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

References

Reviewer guidance

Testing checklist

PR process

Reviewer checklist

Uh oh!

github-actions bot commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rtibbles left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jredrejo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akolson Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akolson Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rtibbles left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

akolson commented Mar 10, 2023 •

edited

Loading

github-actions bot commented Mar 10, 2023 •

edited

Loading

akolson Mar 13, 2023 •

edited

Loading

akolson Mar 13, 2023 •

edited

Loading