adds ability to explore channel on 'Explore Libraries' page#10248
Merged
rtibbles merged 2 commits intolearningequality:developfrom Mar 20, 2023
Merged
adds ability to explore channel on 'Explore Libraries' page#10248rtibbles merged 2 commits intolearningequality:developfrom
rtibbles merged 2 commits intolearningequality:developfrom
Conversation
github-actions
bot
added
APP: Learn
Contributor
Build Artifacts
|
rtibbles
reviewed
Mar 20, 2023
kolibri/plugins/learn/assets/src/views/ExploreLibrariesPage/LibraryItem.vue
Outdated
Show resolved
Hide resolved
rtibbles
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr adds routing links to the existing channels displayed on the new
Explore Librariespage. Please note that the existingLibraryPageis reused to view a particular library. As such, the logic to explore a channel is already present thus no updates are required.References
Closes #9855
Reviewer guidance
/learn/#/explore_librariesvia the address barChanneland you should be able to explore the channel.Please note that this works only for remote or local devices but not channels in Kolibri Studio due to adds logic to LibraryPage to optionally display a particular device's… #10227 (review)
Testing checklist
PR process
Reviewer checklist
yarnandpip)