Fix: Improve Request Port Extraction Handling in ServeCommand.php #53537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prep Laravel v12 * wip * Temp constraint on prompts * wip
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # src/Illuminate/Foundation/Application.php
# Conflicts: # CHANGELOG.md # src/Illuminate/Foundation/Application.php
# Conflicts: # CHANGELOG.md # composer.json # src/Illuminate/Foundation/Application.php
# Conflicts: # composer.json
# Conflicts: # composer.json
# Conflicts: # CHANGELOG.md # src/Illuminate/Foundation/Application.php
# Conflicts: # composer.json
* make Str::is() support multiline strings * more tests with patterns containing new lines * cs * cs
# Conflicts: # CHANGELOG.md # composer.json # src/Illuminate/Foundation/Application.php
# Conflicts: # CHANGELOG.md # src/Illuminate/Foundation/Application.php
# Conflicts: # CHANGELOG.md # src/Illuminate/Foundation/Application.php
…#51544) * [12.x] Adds missing streamJson() to ResponseFactory contact * Update ResponseFactory.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
# Conflicts: # CHANGELOG.md # src/Illuminate/Foundation/Application.php
# Conflicts: # CHANGELOG.md # composer.json # src/Illuminate/Foundation/Application.php # src/Illuminate/Log/composer.json
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Close laravel#52954 This PR remove the duplicated prefix when use DynamoDB as cache drive and try to lock DynamoDB Key now: laravel_cache_laravel_cache_my-lock DynamoDB Key after: laravel_cache_my-lock
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
…dw/laravel-framework into calebdw-default_datetime_precision
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
* Add missing docblock * Fixes new tests to be compatible with 12.x code Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
* fix test namespace. Signed-off-by: Ola Valø Pettersen <ola@24nettbutikk.no> * map concurrency output to array keys on input. Signed-off-by: Ola Valø Pettersen <ola@24nettbutikk.no> * modify forkDriver to use input index for output. Signed-off-by: Ola Valø Pettersen <ola@24nettbutikk.no> * comment out tests, as the package is not preset by default. Signed-off-by: Ola Valø Pettersen <ola@24nettbutikk.no> * Remove unnecessary PHPStan ignore comment Signed-off-by: Ola Valø Pettersen <ola@24nettbutikk.no> * fix comment format Signed-off-by: Ola Valø Pettersen <ola@24nettbutikk.no> * formatting Signed-off-by: Ola Valø Pettersen <ola@24nettbutikk.no> * Update ForkDriver.php --------- Signed-off-by: Ola Valø Pettersen <ola@24nettbutikk.no> Co-authored-by: Taylor Otwell <taylor@laravel.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
…aravel#53304) the way `partition` currently works is it returns an `Eloquent\Collection` of `Eloquent\Collection`s, which is technically not allowed by the generic type hints defined by the class, and also doesn't really make any logical sense for how someone would want to use this. It also causes issues in the IDE because based on the type hints it assumes ALL values of an `Eloquent\Collection` are of type `Eloquent\Model`, which is not the case for the `partition` method. what we really want is a `Support\Collection` of `Eloquent\Collection`s. we can accomplish this by first calling the `parent::partition` method to get our (illegal) result of `Eloquent\Collection<int, Eloquent\Collection>`, and then converting it to a base collection to end up with the desired `Support\Collection<int, Eloquent\Collection>`.
…aravel#53231) * Tweaks the RefreshDatabase trait for better support of multi-dbs When working with multiple databases and some of them are in-memory while others are regular disk-based databases, we usually have to override some of the traits methods to make it work. Also, the database restoration process doesn't handle multiple DBs that well. With these changes, when an app needs to support multiple databases, the user will have to do a few steps: 1. Set the `$connectionsToTransact` protected property on the TestCase listing all connections they use 1. Override the `migrateDatabase` method and call all the migrate:fresh commands for all their connections Restoring the databases between tests should now be completely handled by the trait, no matter which database connection uses in-memory databases or not. * formatting --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
* Validate UUID's version optionally * StyleCI fixes * Reorder imports * Check type before length * Fix wrong variable * Symfony/uid doesn't implement version 2 * fix: 🐛 Cast extracted value for identity check of match * test: ✅ Add tests for both Str::isUuid() and the uuid validation rule * style: 🎨 Fix StyleCI error Suggested-by: Vano Devium <vano@devium.me> cc: Vano Devium <vano@devium.me> thanks-to: Vano Devium <vano@devium.me> original-patch-by: Vano Devium <vano@devium.me> based-on-a-patch-by: Vano Devium <vano@devium.me> based-on-patch-by: Vano Devium <vano@devium.me> credit-to: Vano Devium <vano@devium.me> inspired-by-patch-by: Vano Devium <vano@devium.me> initial-work-by: Vano Devium <vano@devium.me> inspired-by: laravel#21672 * test: ✅ Add non-existent UUID version cases to data provider Suggested-by: Vano Devium <webdevium@gmail.com> cc: Vano Devium <webdevium@gmail.com> thanks-to: Vano Devium <webdevium@gmail.com> original-patch-by: Vano Devium <webdevium@gmail.com> based-on-a-patch-by: Vano Devium <webdevium@gmail.com> based-on-patch-by: Vano Devium <webdevium@gmail.com> credit-to: Vano Devium <webdevium@gmail.com> inspired-by-patch-by: Vano Devium <webdevium@gmail.com> initial-work-by: Vano Devium <webdevium@gmail.com> inspired-by: laravel#21672
* feat: ✨ Add support for UUID v2 and max UUID validation * test: ✅ Add cases for every supported UUID version to data provider of UUID validation tests * style: 🎨 Fix StyleCI errors – Remove unused imports – Spacing improves: laravel#53341 * Add missing import * style: 🎨 Remove indent from blank line * Add ramsey/uuid to composer suggestions to be able to use it for UUID version constraint validation * Update Str.php * Update Str.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
* add step in collection range * add step in collection range * add step in collection range --------- Co-authored-by: Ashot Gharakeshishyan <a.gharakeshishyan@aico.swiss>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
ahmad-cit22
changed the title
ahmad-cit22
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
23 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some mistake when this PR was created. Kindly check the updated PR: #53538