Validation rule for UUID #21672
Closed
Validation rule for UUID #21672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your tests could be refactored with dataProviders 🚀 |
|
Don't want to include this in the core right now. Would make a good package candidate using the new class based validation rules. |
|
As @taylorotwell mentioned, you can submit as a package to https://github.com/laravel-validation-rules perhaps :) |
shaedrich
added a commit
to shaedrich/framework
that referenced
this pull request
Oct 30, 2024
Suggested-by: Vano Devium <vano@devium.me> cc: Vano Devium <vano@devium.me> thanks-to: Vano Devium <vano@devium.me> original-patch-by: Vano Devium <vano@devium.me> based-on-a-patch-by: Vano Devium <vano@devium.me> based-on-patch-by: Vano Devium <vano@devium.me> credit-to: Vano Devium <vano@devium.me> inspired-by-patch-by: Vano Devium <vano@devium.me> initial-work-by: Vano Devium <vano@devium.me> inspired-by: laravel#21672
shaedrich
added a commit
to shaedrich/framework
that referenced
this pull request
Oct 30, 2024
Suggested-by: Vano Devium <webdevium@gmail.com> cc: Vano Devium <webdevium@gmail.com> thanks-to: Vano Devium <webdevium@gmail.com> original-patch-by: Vano Devium <webdevium@gmail.com> based-on-a-patch-by: Vano Devium <webdevium@gmail.com> based-on-patch-by: Vano Devium <webdevium@gmail.com> credit-to: Vano Devium <webdevium@gmail.com> inspired-by-patch-by: Vano Devium <webdevium@gmail.com> initial-work-by: Vano Devium <webdevium@gmail.com> inspired-by: laravel#21672
taylorotwell
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Validate UUID's version optionally * StyleCI fixes * Reorder imports * Check type before length * Fix wrong variable * Symfony/uid doesn't implement version 2 * fix: 🐛 Cast extracted value for identity check of match * test: ✅ Add tests for both Str::isUuid() and the uuid validation rule * style: 🎨 Fix StyleCI error Suggested-by: Vano Devium <vano@devium.me> cc: Vano Devium <vano@devium.me> thanks-to: Vano Devium <vano@devium.me> original-patch-by: Vano Devium <vano@devium.me> based-on-a-patch-by: Vano Devium <vano@devium.me> based-on-patch-by: Vano Devium <vano@devium.me> credit-to: Vano Devium <vano@devium.me> inspired-by-patch-by: Vano Devium <vano@devium.me> initial-work-by: Vano Devium <vano@devium.me> inspired-by: #21672 * test: ✅ Add non-existent UUID version cases to data provider Suggested-by: Vano Devium <webdevium@gmail.com> cc: Vano Devium <webdevium@gmail.com> thanks-to: Vano Devium <webdevium@gmail.com> original-patch-by: Vano Devium <webdevium@gmail.com> based-on-a-patch-by: Vano Devium <webdevium@gmail.com> based-on-patch-by: Vano Devium <webdevium@gmail.com> credit-to: Vano Devium <webdevium@gmail.com> inspired-by-patch-by: Vano Devium <webdevium@gmail.com> initial-work-by: Vano Devium <webdevium@gmail.com> inspired-by: #21672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support versions 1..5, as explained in 4122 RFC, chapter 4.1.3 and nil UUID, as explained in 4122 RFC, chapter 4.1.7
Examples: